forgot to check this in earlier - no confusion between types and member names!

dev/pcidev.cc:
    member variables should begin with lowercase so they don't get confused with types.
dev/pcidev.hh:
    member variables must begin with lowercase so they don't get confused with types.

--HG--
extra : convert_revision : f083baa60d0fbf64d858d684ff70ee06e7b7765d

diff --git a/dev/pcidev.cc b/dev/pcidev.cc
index 0e0b7f840002cbd8aa742026274b495b96e076c5..2b2f54fce81f5eba2a4b061bfbb2b6d303a462f9 100644 (file)
--- a/dev/pcidev.cc
+++ b/dev/pcidev.cc
@@ -53,8 +53,8 @@ using namespace std;
 
 PciDev::PciDev(const string &name, MemoryController *mmu, PciConfigAll *cf,
                PciConfigData *cd, uint32_t bus, uint32_t dev, uint32_t func)
-    : FunctionalMemory(name), MMU(mmu), ConfigSpace(cf), ConfigData(cd),
-      Bus(bus), Device(dev), Function(func)
+    : FunctionalMemory(name), MMU(mmu), configSpace(cf), configData(cd),
+      bus(bus), device(dev), function(func)
 {
     // copy the config data from the PciConfigData object
     if (cd) {
@@ -79,21 +79,21 @@ PciDev::ReadConfig(int offset, int size, uint8_t *data)
         memcpy((uint32_t*)data, config.data + offset, sizeof(uint32_t));
         DPRINTF(PCIDEV,
                 "read device: %#x function: %#x register: %#x data: %#x\n",
-                Device, Function, offset, *(uint32_t*)(config.data + offset));
+                device, function, offset, *(uint32_t*)(config.data + offset));
         break;
 
       case sizeof(uint16_t):
         memcpy((uint16_t*)data, config.data + offset, sizeof(uint16_t));
         DPRINTF(PCIDEV,
                 "read device: %#x function: %#x register: %#x data: %#x\n",
-                Device, Function, offset, *(uint16_t*)(config.data + offset));
+                device, function, offset, *(uint16_t*)(config.data + offset));
         break;
 
       case sizeof(uint8_t):
         memcpy((uint8_t*)data, config.data + offset, sizeof(uint8_t));
         DPRINTF(PCIDEV,
                 "read device: %#x function: %#x register: %#x data: %#x\n",
-                Device, Function, offset, (uint16_t)(*(uint8_t*)(config.data + offset)));
+                device, function, offset, (uint16_t)(*(uint8_t*)(config.data + offset)));
         break;
 
       default:
@@ -115,7 +115,7 @@ PciDev::WriteConfig(int offset, int size, uint32_t data)
 
     DPRINTF(PCIDEV,
             "write device: %#x function: %#x reg: %#x size: %#x data: %#x\n",
-            Device, Function, offset, size, word_value);
+            device, function, offset, size, word_value);
 
     barnum = (offset - PCI0_BASE_ADDR0) >> 2;
 

diff --git a/dev/pcidev.hh b/dev/pcidev.hh
index 6496791b27edd58bf558aac6592730baab4220ce..1a45f5c7b92e46ed5fe1a5f25df4e79ed0342fcb 100644 (file)
--- a/dev/pcidev.hh
+++ b/dev/pcidev.hh
@@ -67,11 +67,11 @@ class PciDev : public FunctionalMemory
 {
   protected:
     MemoryController *MMU;
-    PciConfigAll *ConfigSpace;
-    PciConfigData *ConfigData;
-    uint32_t Bus;
-    uint32_t Device;
-    uint32_t Function;
+    PciConfigAll *configSpace;
+    PciConfigData *configData;
+    uint32_t bus;
+    uint32_t device;
+    uint32_t function;
 
     PCIConfig config;
     uint32_t BARSize[6];