PR c++/86608 - reading constexpr volatile variable.

	* constexpr.c (potential_constant_expression_1): Check want_rval
	instead of checking if we have a decl.
	* decl2.c (decl_maybe_constant_var_p): Don't consider volatile
	constexpr variables as maybe constant.

	* g++.dg/cpp0x/constexpr-volatile2.C: New test.
	* g++.dg/cpp0x/pr65327.C: Add dg-error.

From-SVN: r267030

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 3e31ba60d0c90838ea37409ff0a72e94b726bc97..3e49922158213a6cb06937e439bc221e6498b548 100644 (file)
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,11 @@
+2018-12-11  Marek Polacek  <polacek@redhat.com>
+
+       PR c++/86608 - reading constexpr volatile variable.
+       * constexpr.c (potential_constant_expression_1): Check want_rval
+       instead of checking if we have a decl.
+       * decl2.c (decl_maybe_constant_var_p): Don't consider volatile
+       constexpr variables as maybe constant.
+
 2018-12-11  Paolo Carlini  <paolo.carlini@oracle.com>
 
        * decl.c (grokvardecl): Add location_t parameter and use it

diff --git a/gcc/cp/constexpr.c b/gcc/cp/constexpr.c
index 1c844a8c2eff20b0c9a184c00f1a5e89d4b53118..44db38029bf6b264929ce4ac9360cfb9e6378f98 100644 (file)
--- a/gcc/cp/constexpr.c
+++ b/gcc/cp/constexpr.c
@@ -5476,10 +5476,11 @@ potential_constant_expression_1 (tree t, bool want_rval, bool strict, bool now,
        available, so we don't bother with switch tracking.  */
     return true;
 
-  if (TREE_THIS_VOLATILE (t) && !DECL_P (t))
+  if (TREE_THIS_VOLATILE (t) && want_rval)
     {
       if (flags & tf_error)
-        error_at (loc, "expression %qE has side-effects", t);
+       error_at (loc, "lvalue-to-rvalue conversion of a volatile lvalue "
+                 "%qE with type %qT", t, TREE_TYPE (t));
       return false;
     }
   if (CONSTANT_CLASS_P (t))

diff --git a/gcc/cp/decl2.c b/gcc/cp/decl2.c
index a8bf28a0cd954a9f2de0837546e43f4fcfb4e590..1b3e758b6253c79c966948c68469a58f4899c9fb 100644 (file)
--- a/gcc/cp/decl2.c
+++ b/gcc/cp/decl2.c
@@ -4313,7 +4313,7 @@ decl_maybe_constant_var_p (tree decl)
   tree type = TREE_TYPE (decl);
   if (!VAR_P (decl))
     return false;
-  if (DECL_DECLARED_CONSTEXPR_P (decl))
+  if (DECL_DECLARED_CONSTEXPR_P (decl) && !TREE_THIS_VOLATILE (decl))
     return true;
   if (DECL_HAS_VALUE_EXPR_P (decl))
     /* A proxy isn't constant.  */

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 8980dd2b2f1dcbcea10a5c4c4754cb042dd5eba6..c6730c234b6762ef8d5a010eb204fa052e4a1f27 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2018-12-11  Marek Polacek  <polacek@redhat.com>
+
+       PR c++/86608 - reading constexpr volatile variable.
+       * g++.dg/cpp0x/constexpr-volatile2.C: New test.
+       * g++.dg/cpp0x/pr65327.C: Add dg-error.
+
 2018-12-11  Paolo Carlini  <paolo.carlini@oracle.com>
 
        * g++.dg/pr53037-4.C: Test the first two locations too.

diff --git a/gcc/testsuite/g++.dg/cpp0x/constexpr-volatile2.C b/gcc/testsuite/g++.dg/cpp0x/constexpr-volatile2.C
new file mode 100644 (file)
index 0000000..0def8d7
--- /dev/null
+++ b/gcc/testsuite/g++.dg/cpp0x/constexpr-volatile2.C
@@ -0,0 +1,13 @@
+// PR c++/86608
+// { dg-do compile { target c++11 } }
+
+template<typename T, T v> struct X {};
+
+int
+main ()
+{
+  static constexpr volatile int a = 3;
+  constexpr volatile int b = 2;
+  return (sizeof(X<decltype(a), a>) // { dg-error "lvalue-to-rvalue conversion of a volatile lvalue" }
+         + sizeof(X<decltype(b), b>)); // { dg-error "lvalue-to-rvalue conversion of a volatile lvalue" }
+}

diff --git a/gcc/testsuite/g++.dg/cpp0x/pr65327.C b/gcc/testsuite/g++.dg/cpp0x/pr65327.C
index c6cefaba69219710124b0f81748a5595c237b3d2..5176b3c32040cc6740d14263ff9396edb44abf6a 100644 (file)
--- a/gcc/testsuite/g++.dg/cpp0x/pr65327.C
+++ b/gcc/testsuite/g++.dg/cpp0x/pr65327.C
@@ -15,4 +15,4 @@ constexpr volatile int
 bar ()
 {
   return i;
-}
+} // { dg-error "lvalue-to-rvalue conversion of a volatile lvalue" }