Require --no-dynamic-linker with -static -E/--dynamic-list

When -static -E/--dynamic-list are passed to linker, linker may create
executable with dynamic sections which aren't supported by run-time.
We require --no-dynamic-linker together with -static -E/--dynamic-list
before adding dynamic symbol table to static executable.

bfd/

	PR ld/19617
	PR ld/21086
	* elflink.c (elf_link_add_object_symbols): Require
	--no-dynamic-linker with -E/--dynamic-list when creating
	dynamic sections.

ld/

	PR ld/19617
	PR ld/21086
	* testsuite/ld-elf/pr19617a.d: Pass --no-dynamic-linker to ld.
	* testsuite/ld-elf/pr19617b.d: Likewise.
	* testsuite/ld-elf/pr19617c.d: Likewise.
	*testsuite/ld-i386/pr19636-4d.d: Likewise.
	* testsuite/ld-elf/readelf.exp: Pass --no-dynamic-linker to ld
	with --export-dynamic.
	* testsuite/ld-elf/shared.exp: Pass --no-dynamic-linker to ld
	with -E.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index ac80a449b048ce42d2c4a7df4c8ed5981c31d5fd..45760207ad2ead79df3c65c8476271c7d7fa1452 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,11 @@
+2017-04-21  H.J. Lu  <hongjiu.lu@intel.com>
+
+       PR ld/19617
+       PR ld/21086
+       * elflink.c (elf_link_add_object_symbols): Require
+       --no-dynamic-linker with -E/--dynamic-list when creating
+       dynamic sections.
+
 2017-04-20  Maciej W. Rozycki  <macro@imgtec.com>
 
        * elflink.c (_bfd_elf_symbol_refs_local_p): Always return TRUE

diff --git a/bfd/elflink.c b/bfd/elflink.c
index 330fad79aa3e5493b3c97d7527fe24296b29e7b1..0d42c4c5f940fd461efa7b058f741dabf55934cc 100644 (file)
--- a/bfd/elflink.c
+++ b/bfd/elflink.c
@@ -3851,6 +3851,7 @@ elf_link_add_object_symbols (bfd *abfd, struct bfd_link_info *info)
       if (!just_syms
          && (bfd_link_pic (info)
              || (!bfd_link_relocatable (info)
+                 && info->nointerp
                  && (info->export_dynamic || info->dynamic)))
          && is_elf_hash_table (htab)
          && info->output_bfd->xvec == abfd->xvec

diff --git a/ld/ChangeLog b/ld/ChangeLog
index fb88dc79dbe34893bd140f9597789cc7a9c77f70..86d9e51a2416a045dcc1b2f699e06c7f79fefb58 100644 (file)
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,16 @@
+2017-04-21  H.J. Lu  <hongjiu.lu@intel.com>
+
+       PR ld/19617
+       PR ld/21086
+       * testsuite/ld-elf/pr19617a.d: Pass --no-dynamic-linker to ld.
+       * testsuite/ld-elf/pr19617b.d: Likewise.
+       * testsuite/ld-elf/pr19617c.d: Likewise.
+       *testsuite/ld-i386/pr19636-4d.d: Likewise.
+       * testsuite/ld-elf/readelf.exp: Pass --no-dynamic-linker to ld
+       with --export-dynamic.
+       * testsuite/ld-elf/shared.exp: Pass --no-dynamic-linker to ld
+       with -E.
+
 2017-04-20  H.J. Lu  <hongjiu.lu@intel.com>
 
        PR ld/21402

diff --git a/ld/testsuite/ld-elf/pr19617a.d b/ld/testsuite/ld-elf/pr19617a.d
index 784aacb940ba8828380cb5903768f46b59da0f1f..132021fbb55e91b8148e84caafb626287116abc1 100644 (file)
--- a/ld/testsuite/ld-elf/pr19617a.d
+++ b/ld/testsuite/ld-elf/pr19617a.d
@@ -1,5 +1,5 @@
 #source: pr19617.s
-#ld: -E
+#ld: -E --no-dynamic-linker
 #readelf : --dyn-syms --wide
 #target: *-*-linux* *-*-gnu* *-*-solaris*
 

diff --git a/ld/testsuite/ld-elf/pr19617b.d b/ld/testsuite/ld-elf/pr19617b.d
index e1dcb714383fc45a0c30a22b758c931286d1e7b4..4d1886f2bd6913e6ff6cc0f267c4a7b2121efcd4 100644 (file)
--- a/ld/testsuite/ld-elf/pr19617b.d
+++ b/ld/testsuite/ld-elf/pr19617b.d
@@ -1,5 +1,5 @@
 #source: pr19617.s
-#ld: --dynamic-list-data
+#ld: --dynamic-list-data --no-dynamic-linker
 #readelf : --dyn-syms --wide
 #target: *-*-linux* *-*-gnu* *-*-solaris*
 

diff --git a/ld/testsuite/ld-elf/pr19617c.d b/ld/testsuite/ld-elf/pr19617c.d
index 00e2e7e2bbb1b8381396a5ba876789308359afb6..9ac8fc1941fce067b2ec0f47625c461c5cd1becc 100644 (file)
--- a/ld/testsuite/ld-elf/pr19617c.d
+++ b/ld/testsuite/ld-elf/pr19617c.d
@@ -1,5 +1,5 @@
 #source: pr19617.s
-#ld: --dynamic-list-data
+#ld: --dynamic-list-data --no-dynamic-linker
 #readelf : --dyn-syms --wide
 #target: *-*-linux* *-*-gnu* *-*-solaris*
 

diff --git a/ld/testsuite/ld-elf/pr21086.c b/ld/testsuite/ld-elf/pr21086.c
new file mode 100644 (file)
index 0000000..8fb892c
--- /dev/null
+++ b/ld/testsuite/ld-elf/pr21086.c
@@ -0,0 +1,8 @@
+#include <stdio.h>
+
+int
+main ()
+{
+  printf ("PASS\n");
+  return 0;
+}

diff --git a/ld/testsuite/ld-elf/pr21086.list b/ld/testsuite/ld-elf/pr21086.list
new file mode 100644 (file)
index 0000000..a4e712f
--- /dev/null
+++ b/ld/testsuite/ld-elf/pr21086.list
@@ -0,0 +1,3 @@
+{
+  main;
+};

diff --git a/ld/testsuite/ld-elf/readelf.exp b/ld/testsuite/ld-elf/readelf.exp
index 92ca1c508a5eb46a1bfdaa3bd439f79cdeeed4ad..6831c191865b1344698b733270239ca58014bdf2 100644 (file)
--- a/ld/testsuite/ld-elf/readelf.exp
+++ b/ld/testsuite/ld-elf/readelf.exp
@@ -43,7 +43,7 @@ if [check_shared_lib_support] {
     run_ld_link_tests [list \
        [list \
            "readelf version information" \
-           "$LFLAGS -e 0 --export-dynamic -T ver_def.ld\
+           "$LFLAGS --no-dynamic-linker -e 0 --export-dynamic -T ver_def.ld\
             --version-script=ver_def.ver" \
            "" "" \
            {ver_def.s} \

diff --git a/ld/testsuite/ld-elf/shared.exp b/ld/testsuite/ld-elf/shared.exp
index 4859170d0ac3a774919f01d34cda9550a41a5fd1..0fd41fff2a25dba41117b91421c3d23ecb11299e 100644 (file)
--- a/ld/testsuite/ld-elf/shared.exp
+++ b/ld/testsuite/ld-elf/shared.exp
@@ -104,13 +104,13 @@ if { [check_gc_sections_available] } {
            "pr20828-v.so"] \
        [list \
            "PR ld/20828 forcibly exported symbol version without section GC" \
-           "$LFLAGS -e foo -E -T pr20828-v.ld" "" "" \
+           "$LFLAGS --no-dynamic-linker -e foo -E -T pr20828-v.ld" "" "" \
            {pr20828-v.s} \
            {{objdump -p pr20828-v.od}} \
            "pr20828-v-1"] \
        [list \
            "PR ld/20828 forcibly exported symbol version with section GC" \
-           "$LFLAGS -e foo --gc-sections -E -T pr20828-v.ld" "" "" \
+           "$LFLAGS --no-dynamic-linker -e foo --gc-sections -E -T pr20828-v.ld" "" "" \
            {pr20828-v.s} \
            {{objdump -p pr20828-v.od}} \
            "pr20828-v-2"]]

diff --git a/ld/testsuite/ld-i386/pr19636-4d.d b/ld/testsuite/ld-i386/pr19636-4d.d
index a9487f0be64558ed771d50e2abe833abc06ec0cf..e3db60989299443356a14b594683dc866318c1bf 100644 (file)
--- a/ld/testsuite/ld-i386/pr19636-4d.d
+++ b/ld/testsuite/ld-i386/pr19636-4d.d
@@ -1,6 +1,6 @@
 #source: pr19636-4.s
 #as: --32
-#ld: -E --defsym foobar=0x100 -m elf_i386
+#ld: -E --defsym foobar=0x100 -m elf_i386 --no-dynamic-linker
 #readelf : --dyn-syms --wide
 
 Symbol table '\.dynsym' contains [0-9]+ entries: