system: update Config.in comment about systemd dependencies
authorThomas Petazzoni <thomas.petazzoni@bootlin.com>
Wed, 12 Sep 2018 14:17:54 +0000 (16:17 +0200)
committerThomas Petazzoni <thomas.petazzoni@bootlin.com>
Fri, 14 Sep 2018 22:05:48 +0000 (00:05 +0200)
In commit 879fa7f82a86ffdc6d1cf7c9bfbb5cf830583d69, the
BR2_INIT_SYSTEMD option was changed to allow selecting with a uClibc
toolchain. Unfortunately, the corresponding Config.in comment, which
was already bogus, was not updated to take into account the numerous
dependencies of BR2_INIT_SYSTEMD.

Due to this, even if you have uClibc enabled, the BR2_INIT_SYSTEMD
option may not be visible, and the Config.in comment may also not be
visible, leaving the user in the dark.

This commit fixes the dependencies of the Config.in comment so that
they match the one of the BR2_INIT_SYSTEMD option.

Reported-by: Raphael Jacob <r.jacob2002@gmail.com>
Cc: Raphael Jacob <r.jacob2002@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
system/Config.in

index d14a864ca5725d1deec9c7321066b8b25b44574f..f63f27b126809020817020e555397843aad57f32 100644 (file)
@@ -137,9 +137,15 @@ config BR2_INIT_SYSTEMD
        select BR2_ROOTFS_MERGED_USR
        select BR2_PACKAGE_SYSTEMD
 
-comment "systemd needs a glibc or uClibc toolchain, headers >= 3.10"
-       depends on !(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC \
-               && BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10)
+comment "systemd needs a glibc or uClibc toolchain w/ wchar, threads, SSP, dynamic library, headers >= 3.10"
+       depends on BR2_PACKAGE_SYSTEMD_ARCH_SUPPORTS
+       depends on BR2_USE_MMU
+       depends on !(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC) || \
+               !BR2_USE_WCHAR || \
+               !BR2_TOOLCHAIN_HAS_THREADS || \
+               !BR2_TOOLCHAIN_HAS_SSP || \
+               BR2_STATIC_LIBS || \
+               !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
 
 config BR2_INIT_NONE
        bool "None"