nir: Silence unused parameter warnings in nir_constant_expression.c
authorIan Romanick <ian.d.romanick@intel.com>
Tue, 25 Aug 2015 16:44:00 +0000 (17:44 +0100)
committerIan Romanick <ian.d.romanick@intel.com>
Mon, 19 Dec 2016 23:55:44 +0000 (15:55 -0800)
nir/nir_constant_expressions.c:290:25: warning: unused parameter 'num_components' [-Wunused-parameter]
 evaluate_ball3(unsigned num_components, nir_const_value *_src)
                         ^
nir/nir_constant_expressions.c: In function 'evaluate_fddx':
nir/nir_constant_expressions.c:1282:57: warning: unused parameter '_src' [-Wunused-parameter]
 evaluate_fddx(unsigned num_components, nir_const_value *_src)
                                                         ^

v2: Unconditionally mark the parameters as MAYBE_UNUSED instead of
conditionally adding (void) casts to keep the generator simple.
Suggested by Jason.

Number of total warnings in my build reduced from 1575 to 1485
(reduction of 89).

Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/compiler/nir/nir_constant_expressions.py

index 6b4d071236c5e3ae75102d2cbe7f7cc02b313ae5..2cc106db794a100fccf8705bac761137a5a2877c 100644 (file)
@@ -267,8 +267,8 @@ struct bool32_vec {
 
 % for name, op in sorted(opcodes.iteritems()):
 static nir_const_value
-evaluate_${name}(unsigned num_components, unsigned bit_size,
-                 nir_const_value *_src)
+evaluate_${name}(MAYBE_UNUSED unsigned num_components, unsigned bit_size,
+                 MAYBE_UNUSED nir_const_value *_src)
 {
    nir_const_value _dst_val = { {0, } };