i965: Fix assertion in brw_reg_type_letters
authorBen Widawsky <benjamin.widawsky@intel.com>
Fri, 28 Nov 2014 22:28:19 +0000 (14:28 -0800)
committerBen Widawsky <benjamin.widawsky@intel.com>
Tue, 3 Mar 2015 03:55:20 +0000 (19:55 -0800)
While using various debugging features (optimization debug, instruction dumping,
etc) this function is called in order to get a readable letter for the type of
unit.

On GEN8, two new units were added, the Qword and the Unsigned Qword (Q, and UQ
respectively). The existing assertion tries to determine that the argument
passed in is within the correct boundary, however, it was using UQ as the upper
limit instead of Q.

To my knowledge you can only hit this case with the branch I am currently
working on, so it doesn't fix any known issues.

Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Reviewed-by: Matt Turner <mattst88@gmail.com>
src/mesa/drivers/dri/i965/brw_eu.c

index a1b7fda93360e435940743dff514dfba8e70e9e8..146202ba24bed3b3140a3a01a52348f331bafc09 100644 (file)
@@ -61,7 +61,7 @@ brw_reg_type_letters(unsigned type)
       [BRW_REGISTER_TYPE_UQ] = "UQ",
       [BRW_REGISTER_TYPE_Q]  = "Q",
    };
-   assert(type <= BRW_REGISTER_TYPE_UQ);
+   assert(type <= BRW_REGISTER_TYPE_Q);
    return names[type];
 }