core/download: don't be needlessly verbose in backends

In 50c8b7e (support/download: support -q in all download backends), the
backend were made to respect the quietness of the main Makefile, when -s
is poassed on the 'make' command line. In doing so, they were all made
to be verbose by default.

However, the verbosity of some of the tools, like scp, is very high, and
is in fact intended for debug purposes.

Drop being verbose by default, just use whatever each tool deems normal
output. Only respect the quietness requested by the user.

Reported-by: Thomas De Schampheleire <patrickdepinguin@gmail.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Reviewed-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

diff --git a/support/download/bzr b/support/download/bzr
index 870ce8d079cbbe9739181b4ed6bec8dac8772471..c5674665310e171c68db4e90cab5dbcf436898a2 100755 (executable)
--- a/support/download/bzr
+++ b/support/download/bzr
@@ -12,7 +12,7 @@ set -e
 #   BZR      : the bzr command to call
 
 
-verbose=-v
+verbose=
 while getopts :q OPT; do
     case "${OPT}" in
     q)  verbose=-q;;

diff --git a/support/download/cp b/support/download/cp
index 132cad728063ab114563823a0a0808208d0ece32..6e29eef1eccb4712d8ea78a3d173a0ba539e000e 100755 (executable)
--- a/support/download/cp
+++ b/support/download/cp
@@ -11,7 +11,12 @@ set -e
 # Environment:
 #   LOCALFILES: the cp command to call
 
+# 'cp' usually does not print anything on its stdout, whereas the
+# other download backends, even if not verbose, at least print some
+# progress information.
+# Make 'cp' verbose by default, so it behaves a bit like the others.
 verbose=-v
+
 while getopts :q OPT; do
     case "${OPT}" in
     q)  verbose=;;

diff --git a/support/download/git b/support/download/git
index fd5f5392ddec9387aa3b6f92ba4a2dd72edf7e73..0e6103b648b3f2a965ebaedf23030a6cabddb3b7 100755 (executable)
--- a/support/download/git
+++ b/support/download/git
@@ -11,7 +11,7 @@ set -e
 # Environment:
 #   GIT      : the git command to call
 
-verbose=-v
+verbose=
 while getopts :q OPT; do
     case "${OPT}" in
     q)  verbose=-q; exec >/dev/null;;

diff --git a/support/download/hg b/support/download/hg
index f6880fafc4096980fd6988d25edb49fcd6a2e023..d6654a1fb619dd5ea18ad64afd161b63add51753 100755 (executable)
--- a/support/download/hg
+++ b/support/download/hg
@@ -11,7 +11,7 @@ set -e
 # Environment:
 #   HG       : the hg command to call
 
-verbose=-v
+verbose=
 while getopts :q OPT; do
     case "${OPT}" in
     q)  verbose=-q;;

diff --git a/support/download/scp b/support/download/scp
index 3d6876ffbc802519a94acaa7f392bb9ed2507582..1a62f30a2fdb99fc93ec32fa1d73a50502e322d4 100755 (executable)
--- a/support/download/scp
+++ b/support/download/scp
@@ -11,7 +11,7 @@ set -e
 # Environment:
 #   SCP       : the scp command to call
 
-verbose=-v
+verbose=
 while getopts :q OPT; do
     case "${OPT}" in
     q)  verbose=-q;;

diff --git a/support/download/wget b/support/download/wget
index 7eb21a4733df04d187c8f11389a9aefa83dafefb..885bcf14ff68fc8fdd399f5b866f26be9fa40af6 100755 (executable)
--- a/support/download/wget
+++ b/support/download/wget
@@ -11,7 +11,7 @@ set -e
 # Environment:
 #   WGET     : the wget command to call
 
-verbose=-v
+verbose=
 while getopts :q OPT; do
     case "${OPT}" in
     q)  verbose=-q;;