Fix exception-specification of std::invoke
authorJonathan Wakely <jwakely@redhat.com>
Thu, 13 Oct 2016 08:55:40 +0000 (09:55 +0100)
committerJonathan Wakely <redi@gcc.gnu.org>
Thu, 13 Oct 2016 08:55:40 +0000 (09:55 +0100)
* include/bits/invoke.h (__invoke): Fix exception-specification.
* include/std/functional (invoke): Likewise.
* testsuite/20_util/function_objects/invoke/1.cc: New test.

From-SVN: r241089

libstdc++-v3/ChangeLog
libstdc++-v3/include/bits/invoke.h
libstdc++-v3/include/std/functional
libstdc++-v3/testsuite/20_util/function_objects/invoke/1.cc [new file with mode: 0644]

index 81ea0e5e0cbb766d5653decbf9195046c8d183e2..5ee2626ed65ef074ca125d5fe861f19a44f5e70f 100644 (file)
@@ -1,3 +1,9 @@
+2016-10-13  Jonathan Wakely  <jwakely@redhat.com>
+
+       * include/bits/invoke.h (__invoke): Fix exception-specification.
+       * include/std/functional (invoke): Likewise.
+       * testsuite/20_util/function_objects/invoke/1.cc: New test.
+
 2016-10-12  Paolo Carlini  <paolo.carlini@oracle.com>
 
        * testsuite/util/testsuite_hooks.h: Rewrite VERIFY in terms of
index 60405b5cc87b60e82e194ce4c8102426e475d7c8..2bbdab73bbec8ed98749eed0a5fb9b281a391928 100644 (file)
@@ -87,7 +87,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
   template<typename _Callable, typename... _Args>
     constexpr typename result_of<_Callable&&(_Args&&...)>::type
     __invoke(_Callable&& __fn, _Args&&... __args)
-    noexcept(__is_nothrow_callable<_Callable(_Args&&...)>::value)
+    noexcept(__is_nothrow_callable<_Callable&&(_Args&&...)>::value)
     {
       using __result_of = result_of<_Callable&&(_Args&&...)>;
       using __type = typename __result_of::type;
index 2587392a25cf8901e2402504dd48ce82b153575b..6a4531477382e1d8f5ca146622a2f701d062d9a4 100644 (file)
@@ -200,7 +200,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
   template<typename _Callable, typename... _Args>
     inline result_of_t<_Callable&&(_Args&&...)>
     invoke(_Callable&& __fn, _Args&&... __args)
-    noexcept(is_nothrow_callable_v<_Callable(_Args&&...)>)
+    noexcept(is_nothrow_callable_v<_Callable&&(_Args&&...)>)
     {
       return std::__invoke(std::forward<_Callable>(__fn),
                           std::forward<_Args>(__args)...);
diff --git a/libstdc++-v3/testsuite/20_util/function_objects/invoke/1.cc b/libstdc++-v3/testsuite/20_util/function_objects/invoke/1.cc
new file mode 100644 (file)
index 0000000..81bf25a
--- /dev/null
@@ -0,0 +1,30 @@
+// Copyright (C) 2016 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-do compile { target c++11 } }
+
+#include <functional>
+
+struct abstract {
+  virtual ~abstract() = 0;
+  void operator()() noexcept;
+};
+
+static_assert( noexcept(std::__invoke(std::declval<abstract>())), "" );
+#if __cpp_lib_invoke
+static_assert( noexcept(std::invoke(std::declval<abstract>())), "" );
+#endif