i965/fs: Connect cfg properly in predicated break peephole.
authorMatt Turner <mattst88@gmail.com>
Sun, 31 Aug 2014 18:07:58 +0000 (11:07 -0700)
committerKenneth Graunke <kenneth@whitecape.org>
Fri, 5 Sep 2014 16:08:59 +0000 (09:08 -0700)
If the ENDIF instruction was the only instruction in its block, we'd
leave the successors of the merged if+jump block in a bad state.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83080
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/mesa/drivers/dri/i965/brw_fs_peephole_predicated_break.cpp

index ab197ee4694b05a2804e4e392683c6fcca027191..eb9968179f2dd115aca964acf92dc0aea18430f0 100644 (file)
@@ -87,13 +87,18 @@ fs_visitor::opt_peephole_predicated_break()
       }
 
       if_inst->remove(if_block);
+
+      bblock_t *later_block = endif_block;
+      if (endif_block->start_ip == endif_block->end_ip) {
+         later_block = (bblock_t *)endif_block->link.next;
+      }
       endif_inst->remove(endif_block);
 
-      if_block->children.make_empty();
-      endif_block->parents.make_empty();
+      earlier_block->children.make_empty();
+      later_block->parents.make_empty();
 
-      if_block->add_successor(cfg->mem_ctx, jump_block);
-      jump_block->add_successor(cfg->mem_ctx, endif_block);
+      earlier_block->add_successor(cfg->mem_ctx, jump_block);
+      jump_block->add_successor(cfg->mem_ctx, later_block);
 
       if (earlier_block->can_combine_with(jump_block)) {
          earlier_block->combine_with(jump_block);