panfrost: Explicitly convert to 32-bit for logic-ops
authorAlyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tue, 2 Jun 2020 00:34:34 +0000 (20:34 -0400)
committerMarge Bot <eric+marge@anholt.net>
Wed, 3 Jun 2020 22:48:10 +0000 (22:48 +0000)
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reported-by: Icecream95 <ixn@keemail.me>
Fixes: 19b4e586f62 ("panfrost: Switch to pan_lower_framebuffer")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5289>

src/gallium/drivers/panfrost/nir/nir_lower_blend.c

index f46f635da4888d901899920af44cfa7b6d5630df..13cef5d6e1413fa90d6c4ae5969ae0da7a030ebe 100644 (file)
@@ -215,6 +215,11 @@ nir_blend_logicop(
    const struct util_format_description *format_desc =
       util_format_description(options.format);
 
+   if (options.half) {
+      src = nir_f2f32(b, src);
+      dst = nir_f2f32(b, dst);
+   }
+
    assert(src->num_components <= 4);
    assert(dst->num_components <= 4);
 
@@ -235,7 +240,12 @@ nir_blend_logicop(
        out = nir_iand(b, out, nir_build_imm(b, 4, 32, mask));
    }
 
-   return nir_format_unorm_to_float(b, out, bits);
+   out = nir_format_unorm_to_float(b, out, bits);
+
+   if (options.half)
+      out = nir_f2f16(b, out);
+
+   return out;
 }
 
 /* Given a blend state, the source color, and the destination color,