arch: Fix a fatal_if in most of the arch's process classes.

When switching an assert to a fatal while addressing recent review
feedback, I forgot to reverse the polarity of the condition, making
the fatal fire in exactly the opposite of the conditions it was meant
to.

Change-Id: Icf49864ef449052bbb0d427dca786006166575c4
Reviewed-on: https://gem5-review.googlesource.com/7381
Reviewed-by: Matthias Jung <jungma@eit.uni-kl.de>
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Maintainer: Jason Lowe-Power <jason@lowepower.com>

diff --git a/src/arch/alpha/process.cc b/src/arch/alpha/process.cc
index bcfe36270d07727c404b608366eecd621f2fb6c0..2c6f833096b8d02a1408ce41bbe2a8670f943678 100644 (file)
--- a/src/arch/alpha/process.cc
+++ b/src/arch/alpha/process.cc
@@ -52,7 +52,7 @@ AlphaProcess::AlphaProcess(ProcessParams *params, ObjectFile *objFile)
     : Process(params, new FuncPageTable(params->name, params->pid, PageBytes),
       objFile)
 {
-    fatal_if(!params->useArchPT, "Arch page tables not implemented.");
+    fatal_if(params->useArchPT, "Arch page tables not implemented.");
     Addr brk_point = objFile->dataBase() + objFile->dataSize() +
                      objFile->bssSize();
     brk_point = roundUp(brk_point, PageBytes);

diff --git a/src/arch/arm/process.cc b/src/arch/arm/process.cc
index 5daa54a1fe57a86cbb7a8e7874b33e54ee090e71..aef714ed37a19eeddf60162f03003f01e460bcf1 100644 (file)
--- a/src/arch/arm/process.cc
+++ b/src/arch/arm/process.cc
@@ -67,7 +67,7 @@ ArmProcess::ArmProcess(ProcessParams *params, ObjectFile *objFile,
               objFile),
               arch(_arch)
 {
-    fatal_if(!params->useArchPT, "Arch page tables not implemented.");
+    fatal_if(params->useArchPT, "Arch page tables not implemented.");
 }
 
 ArmProcess32::ArmProcess32(ProcessParams *params, ObjectFile *objFile,

diff --git a/src/arch/mips/process.cc b/src/arch/mips/process.cc
index 76f7e869c0f87db507519fe3a48ac9bb79605264..62ccd5afe4e8d5965c48c03270ea8f3d6f585320 100644 (file)
--- a/src/arch/mips/process.cc
+++ b/src/arch/mips/process.cc
@@ -53,7 +53,7 @@ MipsProcess::MipsProcess(ProcessParams *params, ObjectFile *objFile)
     : Process(params, new FuncPageTable(params->name, params->pid, PageBytes),
               objFile)
 {
-    fatal_if(!params->useArchPT, "Arch page tables not implemented.");
+    fatal_if(params->useArchPT, "Arch page tables not implemented.");
     // Set up stack. On MIPS, stack starts at the top of kuseg
     // user address space. MIPS stack grows down from here
     Addr stack_base = 0x7FFFFFFF;

diff --git a/src/arch/power/process.cc b/src/arch/power/process.cc
index 343cd4b4e0bdc56aa2f0c373f97e2395f15e9bac..22627efe5e93d3ebbbb31758115d91902d2c4df3 100644 (file)
--- a/src/arch/power/process.cc
+++ b/src/arch/power/process.cc
@@ -53,7 +53,7 @@ PowerProcess::PowerProcess(ProcessParams *params, ObjectFile *objFile)
     : Process(params, new FuncPageTable(params->name, params->pid, PageBytes),
               objFile)
 {
-    fatal_if(!params->useArchPT, "Arch page tables not implemented.");
+    fatal_if(params->useArchPT, "Arch page tables not implemented.");
     // Set up break point (Top of Heap)
     Addr brk_point = objFile->dataBase() + objFile->dataSize() +
                      objFile->bssSize();

diff --git a/src/arch/riscv/process.cc b/src/arch/riscv/process.cc
index 44b276a4bbd9c611a6a6e1ab694085366a60ce9a..73df5f50d0d04a18b0b115445b36f1614a7ce67a 100644 (file)
--- a/src/arch/riscv/process.cc
+++ b/src/arch/riscv/process.cc
@@ -64,7 +64,7 @@ RiscvProcess::RiscvProcess(ProcessParams *params, ObjectFile *objFile) :
                                           PageBytes),
                 objFile)
 {
-    fatal_if(!params->useArchPT, "Arch page tables not implemented.");
+    fatal_if(params->useArchPT, "Arch page tables not implemented.");
     const Addr stack_base = 0x7FFFFFFFFFFFFFFFL;
     const Addr max_stack_size = 8 * 1024 * 1024;
     const Addr next_thread_stack_base = stack_base - max_stack_size;

diff --git a/src/arch/sparc/process.cc b/src/arch/sparc/process.cc
index 59ef5c4ac6cb6b9ffea298ade0616f4c6c6418ff..1fcb6cba34259a43b6471e163b48cf1e91280a2e 100644 (file)
--- a/src/arch/sparc/process.cc
+++ b/src/arch/sparc/process.cc
@@ -60,7 +60,7 @@ SparcProcess::SparcProcess(ProcessParams *params, ObjectFile *objFile,
               objFile),
       StackBias(_StackBias)
 {
-    fatal_if(!params->useArchPT, "Arch page tables not implemented.");
+    fatal_if(params->useArchPT, "Arch page tables not implemented.");
     // Initialize these to 0s
     fillStart = 0;
     spillStart = 0;