[PR c++/84729] reject parenthesized array init

A parenthesized initializer was only accepted when new()ing an array in
permissive mode.  We were not careful, however, to convert the
TREE_LIST initializer to the array element type in this extension.

Instead of fixing it, converting the initializer to the base type
after turning the TREE_LIST initializer to a compound_expr, we disable
this deprecated extension.

for  gcc/cp/ChangeLog

	PR c++/84729
	* init.c (build_vec_init): Error at parenthesized array init.

for  gcc/testsuite/ChangeLog

	PR c++/84729
	* g++.dg/pr84729.C: New.
        * g++.old-deja/g++.ext/arrnew2.C: Require error.
	* g++.old-deja/g++.robertl/eb58.C: Likewise.
	* g++.old-deja/g++.robertl/eb63.C: Likewise.

From-SVN: r258791

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 5dae29d23a14f899b0b7ba45a0dc7340ab1a780a..33add697a8648b8756006971f3f5499e1981ab73 100644 (file)
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,5 +1,8 @@
 2018-03-22  Alexandre Oliva <aoliva@redhat.com>
 
+       PR c++/84729
+       * init.c (build_vec_init): Error at parenthesized array init.
+
        PR c++/84610
        PR c++/84642
        PR c++/84942

diff --git a/gcc/cp/init.c b/gcc/cp/init.c
index 3215c23855406064ad642e8487f234cff0ce3816..ff52c42c1ad85f7446cd77be876d64c0aeb86c17 100644 (file)
--- a/gcc/cp/init.c
+++ b/gcc/cp/init.c
@@ -3370,11 +3370,8 @@ build_new_1 (vec<tree, va_gc> **placement, tree type, tree nelts,
          else if (*init)
             {
               if (complain & tf_error)
-                permerror (input_location,
-                          "parenthesized initializer in array new");
-              else
-                return error_mark_node;
-             vecinit = build_tree_list_vec (*init);
+                error ("parenthesized initializer in array new");
+             return error_mark_node;
             }
          init_expr
            = build_vec_init (data_addr,

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index d4b8c275d558100da0086b088811e228d5dc1116..07951d99ba9f658426c1c1d04c4993838c766bc7 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,11 @@
+2018-03-22  Alexandre Oliva <aoliva@redhat.com>
+
+       PR c++/84729
+       * g++.dg/pr84729.C: New.
+       * g++.old-deja/g++.ext/arrnew2.C: Require error.
+       * g++.old-deja/g++.robertl/eb58.C: Likewise.
+       * g++.old-deja/g++.robertl/eb63.C: Likewise.
+
 2018-03-22  Steven G. Kargl  <kargl@gcc.gnu.org
 
        PR fortran/84922

diff --git a/gcc/testsuite/g++.dg/pr84729.C b/gcc/testsuite/g++.dg/pr84729.C
new file mode 100644 (file)
index 0000000..e5d689e
--- /dev/null
+++ b/gcc/testsuite/g++.dg/pr84729.C
@@ -0,0 +1,7 @@
+// { dg-do compile }
+// { dg-options "-fpermissive" }
+
+typedef int b[2];
+void a() {
+  new b(a); // { dg-error "parenthesized initializer in array new" }
+}

diff --git a/gcc/testsuite/g++.old-deja/g++.ext/arrnew2.C b/gcc/testsuite/g++.old-deja/g++.ext/arrnew2.C
index c6a967ccc38516e9a81d3b14bb3de317270afc4f..aff6b9c7c63b4e1e19e57d000635e34ec1c70a98 100644 (file)
--- a/gcc/testsuite/g++.old-deja/g++.ext/arrnew2.C
+++ b/gcc/testsuite/g++.old-deja/g++.ext/arrnew2.C
@@ -1,7 +1,7 @@
-// { dg-do run }
+// { dg-do compile }
 // { dg-options "-w -fpermissive" }
 
-int *foo = new int[1](42); // { dg-bogus "" }
+int *foo = new int[1](42); // { dg-error "parenthesized" }
 int main ()
 {
   return foo[0] != 42;

diff --git a/gcc/testsuite/g++.old-deja/g++.robertl/eb58.C b/gcc/testsuite/g++.old-deja/g++.robertl/eb58.C
index 04ec92a30afce9e6e6cbdf7af19b144e63d73b95..d702296bdc7810ef3b7e76e53364b83640783540 100644 (file)
--- a/gcc/testsuite/g++.old-deja/g++.robertl/eb58.C
+++ b/gcc/testsuite/g++.old-deja/g++.robertl/eb58.C
@@ -1,4 +1,4 @@
-// { dg-do run  }
+// { dg-do compile  }
 // { dg-options "-w -fpermissive" }
 // Test for g++ array init extension 
 
@@ -11,5 +11,5 @@ private:
 
 main()
 {
-  A *list = new A[10](4);
+  A *list = new A[10](4); // { dg-error "parenthesized" }
 }

diff --git a/gcc/testsuite/g++.old-deja/g++.robertl/eb63.C b/gcc/testsuite/g++.old-deja/g++.robertl/eb63.C
index a49fb02641cdc2dd794051635fc956270302aeea..653351b8dfad9297e5489d29fd90617caa080fa7 100644 (file)
--- a/gcc/testsuite/g++.old-deja/g++.robertl/eb63.C
+++ b/gcc/testsuite/g++.old-deja/g++.robertl/eb63.C
@@ -1,4 +1,4 @@
-// { dg-do run  }
+// { dg-do compile  }
 // { dg-options "-w -fpermissive" }
 //This uses GNU extensions, so disable -ansi
 #include <stdio.h>
@@ -13,5 +13,5 @@ public:
 main() {
         A* a;
 
-        a = new A[2](1,false);
+        a = new A[2](1,false); // { dg-error "parenthesized" }
 }