Don't leak ISA to __attribute__ ((target("arch=XXX")))

When processing __attribute__ ((target("arch=XXX"))), we should clear
the ISA bits in x_ix86_isa_flags first to avoid leaking ISA from
command line.

gcc/

	PR target/67995
	* config/i386/i386.c (ix86_valid_target_attribute_tree): If
	arch= is set,  clear all bits in x_ix86_isa_flags, except for
	ISA_64BIT, ABI_64, ABI_X32, and CODE16.

gcc/testsuite/

	PR target/67995
	* gcc.target/i386/pr67995-1.c: New test.
	* gcc.target/i386/pr67995-2.c: Likewise.
	* gcc.target/i386/pr67995-3.c: Likewise.

From-SVN: r228967

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 43d6a3f83bf0b0054896af0ae3f2c2a20a42bd94..5ec6b3c88a3b4e6063c84d8463cc7402b1422312 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2015-10-19  H.J. Lu  <hongjiu.lu@intel.com>
+
+       PR target/67995
+       * config/i386/i386.c (ix86_valid_target_attribute_tree): If
+       arch= is set,  clear all bits in x_ix86_isa_flags, except for
+       ISA_64BIT, ABI_64, ABI_X32, and CODE16.
+
 2015-10-19  Joost VandeVondele  <vondele@gnu.gcc.org>
 
        PR middle-end/68002

diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
index 6032d370f8ca4a00f835f6fc6a97c7e865a985ee..1049455aa2a2512d91d1daa5c6fff4b97e86357f 100644 (file)
--- a/gcc/config/i386/i386.c
+++ b/gcc/config/i386/i386.c
@@ -6129,7 +6129,18 @@ ix86_valid_target_attribute_tree (tree args,
       /* If we are using the default tune= or arch=, undo the string assigned,
         and use the default.  */
       if (option_strings[IX86_FUNCTION_SPECIFIC_ARCH])
-       opts->x_ix86_arch_string = option_strings[IX86_FUNCTION_SPECIFIC_ARCH];
+       {
+         opts->x_ix86_arch_string
+           = option_strings[IX86_FUNCTION_SPECIFIC_ARCH];
+
+         /* If arch= is set,  clear all bits in x_ix86_isa_flags,
+            except for ISA_64BIT, ABI_64, ABI_X32, and CODE16.  */
+         opts->x_ix86_isa_flags &= (OPTION_MASK_ISA_64BIT
+                                    | OPTION_MASK_ABI_64
+                                    | OPTION_MASK_ABI_X32
+                                    | OPTION_MASK_CODE16);
+
+       }
       else if (!orig_arch_specified)
        opts->x_ix86_arch_string = NULL;
 

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index f24730e18562f310e2fe59358f24b260861bb824..a717ccaa3554916952fdbe3f6ee83eba66889077 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,10 @@
+2015-10-19  H.J. Lu  <hongjiu.lu@intel.com>
+
+       PR target/67995
+       * gcc.target/i386/pr67995-1.c: New test.
+       * gcc.target/i386/pr67995-2.c: Likewise.
+       * gcc.target/i386/pr67995-3.c: Likewise.
+
 2015-10-19  Joost VandeVondele  <vondele@gnu.gcc.org>
 
        PR middle-end/68002

diff --git a/gcc/testsuite/gcc.target/i386/pr67995-1.c b/gcc/testsuite/gcc.target/i386/pr67995-1.c
new file mode 100644 (file)
index 0000000..072b1fe
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr67995-1.c
@@ -0,0 +1,16 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -march=haswell" } */
+
+unsigned int
+__attribute__ ((target("arch=core2")))
+__x86_rdrand(void)
+{
+  unsigned int retries = 100;
+  unsigned int val;
+
+  while (__builtin_ia32_rdrand32_step(&val) == 0) /* { dg-error "needs isa option" } */
+    if (--retries == 0)
+      return 0;
+
+  return val;
+}

diff --git a/gcc/testsuite/gcc.target/i386/pr67995-2.c b/gcc/testsuite/gcc.target/i386/pr67995-2.c
new file mode 100644 (file)
index 0000000..632bb63
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr67995-2.c
@@ -0,0 +1,16 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -march=core2" } */
+
+unsigned int
+__attribute__ ((target("arch=haswell")))
+__x86_rdrand(void)
+{
+  unsigned int retries = 100;
+  unsigned int val;
+
+  while (__builtin_ia32_rdrand32_step(&val) == 0)
+    if (--retries == 0)
+      return 0;
+
+  return val;
+}

diff --git a/gcc/testsuite/gcc.target/i386/pr67995-3.c b/gcc/testsuite/gcc.target/i386/pr67995-3.c
new file mode 100644 (file)
index 0000000..11993b7
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr67995-3.c
@@ -0,0 +1,16 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -march=core2" } */
+
+unsigned int
+__attribute__ ((target("rdrnd")))
+__x86_rdrand(void)
+{
+  unsigned int retries = 100;
+  unsigned int val;
+
+  while (__builtin_ia32_rdrand32_step(&val) == 0)
+    if (--retries == 0)
+      return 0;
+
+  return val;
+}