radeonsi: remove TODO and correct a comment in si_emit_cache_flush
authorMarek Olšák <marek.olsak@amd.com>
Sun, 17 Apr 2016 13:34:24 +0000 (15:34 +0200)
committerMarek Olšák <marek.olsak@amd.com>
Mon, 18 Apr 2016 17:51:25 +0000 (19:51 +0200)
Yes, that flag is really needed.

Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>
src/gallium/drivers/radeonsi/si_state_draw.c

index 40cad504e09f31025fcab477f726b6558c1699e7..8f4eba4151e02f40fdc45717c31aebfc1c116afe 100644 (file)
@@ -615,7 +615,7 @@ void si_emit_cache_flush(struct si_context *si_ctx, struct r600_atom *atom)
         * doesn't seem to work reliably. Since the bug doesn't affect
         * correctness (it only does more work than necessary) and
         * the performance impact is likely negligible, there is no plan
-        * to fix it.
+        * to add a workaround for it.
         */
 
        if (sctx->flags & SI_CONTEXT_INV_ICACHE)
@@ -628,7 +628,6 @@ void si_emit_cache_flush(struct si_context *si_ctx, struct r600_atom *atom)
        if (sctx->flags & SI_CONTEXT_INV_GLOBAL_L2) {
                cp_coher_cntl |= S_0085F0_TC_ACTION_ENA(1);
 
-               /* TODO: this might not be needed. */
                if (sctx->chip_class >= VI)
                        cp_coher_cntl |= S_0301F0_TC_WB_ACTION_ENA(1);
        }