plugin.c (try_init_one_plugin): Fix ressource leaks (CID 726637)

From-SVN: r248088

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index f94e442657fbbd37e2db05fddea833029e9ab28b..48f1bee8e97eecda9749ce26a13968e7079a7d82 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,7 @@
+2017-05-15  Sylvestre Ledru  <sylvestre@debian.org>
+
+       plugin.c (try_init_one_plugin): Fix ressource leaks (CID 726637)
+
 2017-05-15  Uros Bizjak  <ubizjak@gmail.com>
 
        PR target/80425

diff --git a/gcc/plugin.c b/gcc/plugin.c
index cfd6ef25036915e7b080cb8d4a50c70060c13d75..c6d3cddd81072d7a077f6fbe8d858a4786da7263 100644 (file)
--- a/gcc/plugin.c
+++ b/gcc/plugin.c
@@ -617,6 +617,7 @@ try_init_one_plugin (struct plugin_name_args *plugin)
 
   if ((err = dlerror ()) != NULL)
     {
+      dlclose(dl_handle);
       error ("cannot find %s in plugin %s\n%s", str_plugin_init_func_name,
              plugin->full_name, err);
       return false;
@@ -625,10 +626,12 @@ try_init_one_plugin (struct plugin_name_args *plugin)
   /* Call the plugin-provided initialization routine with the arguments.  */
   if ((*plugin_init) (plugin, &gcc_version))
     {
+      dlclose(dl_handle);
       error ("fail to initialize plugin %s", plugin->full_name);
       return false;
     }
-
+  /* leak dl_handle on purpose to ensure the plugin is loaded for the
+     entire run of the compiler. */
   return true;
 }