mesa: fix crash when an ATI_fs pass begins with an alpha inst

This fixes crash when:
- first pass begins with alpha inst
- first pass ends with color inst, second pass begins with alpha inst
Also, use the symbolic name instead of a number.

Piglit: spec/ati_fragment_shader/api-alphafirst

v2: fixed formatting

Signed-off-by: Miklós Máté <mtmkls@gmail.com>

diff --git a/src/mesa/main/atifragshader.c b/src/mesa/main/atifragshader.c
index 49ddb6e5af6eff6ed139e5c96e75b4ada219cfa7..d61455e12f82c4b0d245446fd15d4ae197be84fb 100644 (file)
--- a/src/mesa/main/atifragshader.c
+++ b/src/mesa/main/atifragshader.c
@@ -597,9 +597,13 @@ _mesa_FragmentOpXATI(GLint optype, GLuint arg_count, GLenum op, GLuint dst,
    else if (curProg->cur_pass==2)
       curProg->cur_pass=3;
 
-   /* decide whether this is a new instruction or not ... all color instructions are new,
-      and alpha instructions might also be new if there was no preceding color inst */
-   if ((optype == 0) || (curProg->last_optype == optype)) {
+   /* Decide whether this is a new instruction or not. All color instructions
+    * are new, and alpha instructions might also be new if there was no
+    * preceding color inst. This may also be the first inst of the pass
+    */
+   if (optype == ATI_FRAGMENT_SHADER_COLOR_OP ||
+       curProg->last_optype == optype ||
+       curProg->numArithInstr[curProg->cur_pass >> 1] == 0) {
       if (curProg->numArithInstr[curProg->cur_pass >> 1] > 7) {
         _mesa_error(ctx, GL_INVALID_OPERATION, "C/AFragmentOpATI(instrCount)");
         return;