anv: Fix descriptor set clean-up on BO allocation failure
authorJason Ekstrand <jason@jlekstrand.net>
Thu, 14 May 2020 03:57:46 +0000 (22:57 -0500)
committerMarge Bot <eric+marge@anholt.net>
Thu, 14 May 2020 16:14:34 +0000 (16:14 +0000)
This was a bit of rebase fail when writing 682c81bdfb.  We stopped
freeing descriptor sets back to the pool and started calling
vk_object_base_finish.  This commit reverts a that hunk should have
never made its way into the final patch.

Fixes: 682c81bdfb "vulkan,anv: Add a base object struct type"
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Tested-by: Mark Janes <mark.a.janes@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5032>

src/intel/vulkan/anv_descriptor_set.c

index d51721b22eab98270ef19de56aef57a9ca04d523..cb6fa40b36894c5a328ef0c51f31cd455dae4047 100644 (file)
@@ -951,7 +951,7 @@ anv_descriptor_set_create(struct anv_device *device,
       uint64_t pool_vma_offset =
          util_vma_heap_alloc(&pool->bo_heap, set_buffer_size, 32);
       if (pool_vma_offset == 0) {
-         vk_object_base_finish(&set->base);
+         anv_descriptor_pool_free_set(pool, set);
          return vk_error(VK_ERROR_FRAGMENTED_POOL);
       }
       assert(pool_vma_offset >= POOL_HEAP_OFFSET &&