* elf.c (bfd_elf_set_group_contents): Revert accidental 2009-01-15

	commit.  Don't write zeros for removed group members.
	(_bfd_elf_copy_private_header_data): Adjust size of group section
	when group members are removed by objcopy.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 3ec31fe64874b4dd23eb99239f5962cab298a1a9..60d0ecc424f1d744dcec693cedeb61d899452c9f 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,10 @@
+2010-02-18  Alan Modra  <amodra@gmail.com>
+
+       * elf.c (bfd_elf_set_group_contents): Revert accidental 2009-01-15
+       commit.  Don't write zeros for removed group members.
+       (_bfd_elf_copy_private_header_data): Adjust size of group section
+       when group members are removed by objcopy.
+
 2010-02-15  Dave Korn  <dave.korn.cygwin@gmail.com>
 
        PR binutils/11280

diff --git a/bfd/elf.c b/bfd/elf.c
index 81a21f54a2948905ff4b96c9d0162edee3f600aa..85ece8b0636b9e33a10815f2515db01a65063503 100644 (file)
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -1,7 +1,7 @@
 /* ELF executable support for BFD.
 
    Copyright 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001,
-   2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009
+   2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010
    Free Software Foundation, Inc.
 
    This file is part of BFD, the Binary File Descriptor library.
@@ -2743,17 +2743,16 @@ bfd_elf_set_group_contents (bfd *abfd, asection *sec, void *failedptrarg)
   while (elt != NULL)
     {
       asection *s;
-      unsigned int idx;
 
       s = elt;
-      if (! elf_discarded_section (s))
+      if (!gas)
+       s = s->output_section;
+      if (s != NULL
+         && !bfd_is_abs_section (s))
        {
+         unsigned int idx = elf_section_data (s)->this_idx;
+
          loc -= 4;
-         if (!gas)
-           s = s->output_section;
-         idx = 0;
-         if (s != NULL)
-           idx = elf_section_data (s)->this_idx;
          H_PUT_32 (abfd, idx, loc);
        }
       elt = elf_next_in_group (elt);
@@ -6160,21 +6159,27 @@ _bfd_elf_copy_private_header_data (bfd *ibfd, bfd *obfd)
        return FALSE;
     }
 
-  /* _bfd_elf_copy_private_section_data copied over the SHF_GROUP flag
-     but this might be wrong if we deleted the group section.  */
   for (isec = ibfd->sections; isec != NULL; isec = isec->next)
-    if (elf_section_type (isec) == SHT_GROUP
-       && isec->output_section == NULL)
+    if (elf_section_type (isec) == SHT_GROUP)
       {
        asection *first = elf_next_in_group (isec);
        asection *s = first;
        while (s != NULL)
          {
-           if (s->output_section != NULL)
+           /* If this member section is being output but the
+              SHT_GROUP section is not, then clear the group info
+              set up by _bfd_elf_copy_private_section_data.  */
+           if (s->output_section != NULL
+               && isec->output_section == NULL)
              {
                elf_section_flags (s->output_section) &= ~SHF_GROUP;
                elf_group_name (s->output_section) = NULL;
              }
+           /* Conversely, if the member section is not being output
+              but the SHT_GROUP section is, then adjust its size.  */
+           else if (s->output_section == NULL
+                    && isec->output_section != NULL)
+             isec->output_section->size -= 4;
            s = elf_next_in_group (s);
            if (s == first)
              break;