re PR middle-end/58385 (likely wrong code bug)

	PR tree-optimization/58385
	* fold-const.c (build_range_check): If both low and high are NULL,
	use omit_one_operand_loc to preserve exp side-effects.

	* gcc.c-torture/execute/pr58385.c: New test.

From-SVN: r202494

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 8b2e2bba301d95ae3eea6a77370f7589ea50de3f..e5e1702e954fff0b5052138d1215dba2ef1d2bbb 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2013-09-11  Jakub Jelinek  <jakub@redhat.com>
+
+       PR tree-optimization/58385
+       * fold-const.c (build_range_check): If both low and high are NULL,
+       use omit_one_operand_loc to preserve exp side-effects.
+
 2013-09-11  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
 
        * config/arm/arm.md (arm_shiftsi3): New alternative l/l/M.

diff --git a/gcc/fold-const.c b/gcc/fold-const.c
index 9956b2c9f0731c0797c6e2e4e8b33e32ff7c9bec..8d57928b95dc8d05fe374ff007b049a49e039451 100644 (file)
--- a/gcc/fold-const.c
+++ b/gcc/fold-const.c
@@ -4299,7 +4299,7 @@ build_range_check (location_t loc, tree type, tree exp, int in_p,
     }
 
   if (low == 0 && high == 0)
-    return build_int_cst (type, 1);
+    return omit_one_operand_loc (loc, type, build_int_cst (type, 1), exp);
 
   if (low == 0)
     return fold_build2_loc (loc, LE_EXPR, type, exp,

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 718e5424a3fd42e0e09c426a62a1dfcb13482da4..c924967ed3be0185fe375c7b69b91324c8aeb1aa 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2013-09-11  Jakub Jelinek  <jakub@redhat.com>
+
+       PR tree-optimization/58385
+       * gcc.c-torture/execute/pr58385.c: New test.
+
 2013-09-11  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
 
        * gcc.target/arm/thumb-ifcvt-2.c: New test.

diff --git a/gcc/testsuite/gcc.c-torture/execute/pr58385.c b/gcc/testsuite/gcc.c-torture/execute/pr58385.c
new file mode 100644 (file)
index 0000000..8d7da6f
--- /dev/null
+++ b/gcc/testsuite/gcc.c-torture/execute/pr58385.c
@@ -0,0 +1,21 @@
+/* PR tree-optimization/58385 */
+
+extern void abort (void);
+
+int a, b = 1;
+
+int
+foo ()
+{
+  b = 0;
+  return 0;
+}
+
+int
+main ()
+{
+  ((0 || a) & foo () >= 0) <= 1 && 1;
+  if (b)
+    abort ();
+  return 0;
+}