Change value::m_stack to bool

This changes value::m_stack to be a bool and updates the various uses.

Reviewed-By: Bruno Larsen <blarsen@redhat.com>

diff --git a/gdb/dwarf2/expr.c b/gdb/dwarf2/expr.c
index 760c5c4b0d0ca1a251d79a50f3f8a6762e3a7859..3f040e7b2d31372b891d2f8dfc34d5faf883faf8 100644 (file)
--- a/gdb/dwarf2/expr.c
+++ b/gdb/dwarf2/expr.c
@@ -1005,7 +1005,7 @@ dwarf_expr_context::fetch_result (struct type *type, struct type *subobj_type,
            retval = value_at_lazy (subobj_type,
                                    address + subobj_offset);
            if (in_stack_memory)
-             retval->set_stack (1);
+             retval->set_stack (true);
          }
          break;
 

diff --git a/gdb/frame-unwind.c b/gdb/frame-unwind.c
index e5f8dc639e3e620ed30c05e7007229fe883addeb..a3673dde77a89294e7173eb1f7aad6b3d7a28e57 100644 (file)
--- a/gdb/frame-unwind.c
+++ b/gdb/frame-unwind.c
@@ -289,7 +289,7 @@ frame_unwind_got_memory (frame_info_ptr frame, int regnum, CORE_ADDR addr)
   struct gdbarch *gdbarch = frame_unwind_arch (frame);
   struct value *v = value_at_lazy (register_type (gdbarch, regnum), addr);
 
-  v->set_stack (1);
+  v->set_stack (true);
   return v;
 }
 

diff --git a/gdb/valops.c b/gdb/valops.c
index 90f7b8c55321c22b792ae6d3926b42300aee84ef..3a1b14c3d44c982cf4dcc21fe9ad565b1ec351ec 100644 (file)
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -1041,7 +1041,7 @@ value_at_lazy (struct type *type, CORE_ADDR addr)
 
 void
 read_value_memory (struct value *val, LONGEST bit_offset,
-                  int stack, CORE_ADDR memaddr,
+                  bool stack, CORE_ADDR memaddr,
                   gdb_byte *buffer, size_t length)
 {
   ULONGEST xfered_total = 0;

diff --git a/gdb/value.c b/gdb/value.c
index ee35f70522857b7c4b8108971258a974a25f2628..bf285a9d50c754b64cbcd57629642242e896e473 100644 (file)
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -3749,7 +3749,7 @@ value::fetch_lazy_memory ()
   gdb_assert (len >= 0);
 
   if (len > 0)
-    read_value_memory (this, 0, stack (), addr,
+    read_value_memory (this, false, stack (), addr,
                       contents_all_raw ().data (), len);
 }
 

diff --git a/gdb/value.h b/gdb/value.h
index 41327ebe3b8618a332e43f587fc99c2808fd4f7b..4cb6fac4104c52e697b46597e39c65b8b6ff678a 100644 (file)
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -135,7 +135,7 @@ private:
     : m_modifiable (true),
       m_lazy (true),
       m_initialized (true),
-      m_stack (0),
+      m_stack (false),
       m_is_zero (false),
       m_in_history (false),
       m_type (type_),
@@ -314,10 +314,10 @@ public:
 
   void set_enclosing_type (struct type *new_type);
 
-  int stack () const
+  bool stack () const
   { return m_stack; }
 
-  void set_stack (int val)
+  void set_stack (bool val)
   { m_stack = val; }
 
   /* If this value is lval_computed, return its lval_funcs
@@ -642,7 +642,7 @@ private:
 
   /* If value is from the stack.  If this is set, read_stack will be
      used instead of read_memory to enable extra caching.  */
-  unsigned int m_stack : 1;
+  bool m_stack : 1;
 
   /* True if this is a zero value, created by 'value::zero'; false
      otherwise.  */
@@ -1000,7 +1000,7 @@ extern struct value *coerce_array (struct value *value);
    whether the memory is known to be stack memory.  */
 
 extern void read_value_memory (struct value *val, LONGEST bit_offset,
-                              int stack, CORE_ADDR memaddr,
+                              bool stack, CORE_ADDR memaddr,
                               gdb_byte *buffer, size_t length);
 
 /* Cast SCALAR_VALUE to the element type of VECTOR_TYPE, then replicate