Remove global call sets: cfgloopanal.c

...or rather, make the use of the default ABI explicit.  That seems
OK if not ideal for this heuristic.

In practical terms, the code patched here is counting GENERAL_REGS,
which are treated in the same way by all concurrent ABI variants
on AArch64.  It might give bad results if used for interrupt
handlers though.

2019-09-30  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
	* cfgloopanal.c: Include regs.h and function-abi.h.
	(init_set_costs): Use default_function_abi to test whether
	a general register is call-clobbered.

From-SVN: r276315

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index a3e4ff24c8d6c461c09f812a9f31b28588c7c5ed..6b08d70e11c4a1253c8038f92095482cef7cd754 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2019-09-30  Richard Sandiford  <richard.sandiford@arm.com>
+
+       * cfgloopanal.c: Include regs.h and function-abi.h.
+       (init_set_costs): Use default_function_abi to test whether
+       a general register is call-clobbered.
+
 2019-09-30  Richard Sandiford  <richard.sandiford@arm.com>
 
        * cfgcleanup.c (old_insns_match_p): Compare the ABIs of calls

diff --git a/gcc/cfgloopanal.c b/gcc/cfgloopanal.c
index 0ebecc37ad8648073a0aaac6c13194ada63b11fc..95ec929c7bde1ba4ce563a9717f3426dcc55db86 100644 (file)
--- a/gcc/cfgloopanal.c
+++ b/gcc/cfgloopanal.c
@@ -32,6 +32,8 @@ along with GCC; see the file COPYING3.  If not see
 #include "graphds.h"
 #include "params.h"
 #include "sreal.h"
+#include "regs.h"
+#include "function-abi.h"
 
 struct target_cfgloop default_target_cfgloop;
 #if SWITCHABLE_TARGET
@@ -353,7 +355,10 @@ init_set_costs (void)
        && !fixed_regs[i])
       {
        target_avail_regs++;
-       if (call_used_or_fixed_reg_p (i))
+       /* ??? This is only a rough heuristic.  It doesn't cope well
+          with alternative ABIs, but that's an optimization rather than
+          correctness issue.  */
+       if (default_function_abi.clobbers_full_reg_p (i))
          target_clobbered_regs++;
       }