re PR tree-optimization/91665 (ICE in build_vector_from_val, at tree.c:1904)

	PR tree-optimization/91665
	* tree-vect-loop.c (vectorizable_reduction): Punt if base has type
	incompatible with the type of PHI result.

	* gcc.dg/vect/pr91665.c: New test.

From-SVN: r275486

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index bf858299322d51f7293edd5eb67c31da9c3420cd..83581ac41bfc3e1abf9ea2c8caeaa657e125de33 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2019-09-07  Jakub Jelinek  <jakub@redhat.com>
+
+       PR tree-optimization/91665
+       * tree-vect-loop.c (vectorizable_reduction): Punt if base has type
+       incompatible with the type of PHI result.
+
 2019-09-07  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 
        PR target/91684

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 9d2c3d2b4fba438b451ad1b2c4712ced4934ae7e..a53887acef9ad4bb9d6d5312c9e3407c8fc0d52a 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2019-09-07  Jakub Jelinek  <jakub@redhat.com>
+
+       PR tree-optimization/91665
+       * gcc.dg/vect/pr91665.c: New test.
+
 2019-09-07  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 
        PR target/91684

diff --git a/gcc/testsuite/gcc.dg/vect/pr91665.c b/gcc/testsuite/gcc.dg/vect/pr91665.c
new file mode 100644 (file)
index 0000000..6b69ea0
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/vect/pr91665.c
@@ -0,0 +1,15 @@
+/* PR tree-optimization/91665 */
+/* { dg-do compile } */
+/* { dg-additional-options "-Ofast" } */
+
+short int v;
+
+void
+foo (short int x, short int y)
+{
+  short int *p = &v;
+
+  x = 1;
+  while (x != 0)
+    x += ++y || (*p = x);
+}

diff --git a/gcc/tree-vect-loop.c b/gcc/tree-vect-loop.c
index b0cbbac0cb5ba1ffce706715d3dbb9139063803d..8324492c7943e76a487255657b1c214e93bfe656 100644 (file)
--- a/gcc/tree-vect-loop.c
+++ b/gcc/tree-vect-loop.c
@@ -6656,10 +6656,13 @@ vectorizable_reduction (stmt_vec_info stmt_info, gimple_stmt_iterator *gsi,
          gcc_assert (TREE_CODE (base) == INTEGER_CST
                      && TREE_CODE (step) == INTEGER_CST);
          cond_reduc_val = NULL_TREE;
+         tree res = PHI_RESULT (STMT_VINFO_STMT (cond_stmt_vinfo));
+         if (!types_compatible_p (TREE_TYPE (res), TREE_TYPE (base)))
+           ;
          /* Find a suitable value, for MAX_EXPR below base, for MIN_EXPR
             above base; punt if base is the minimum value of the type for
             MAX_EXPR or maximum value of the type for MIN_EXPR for now.  */
-         if (tree_int_cst_sgn (step) == -1)
+         else if (tree_int_cst_sgn (step) == -1)
            {
              cond_reduc_op_code = MIN_EXPR;
              if (tree_int_cst_sgn (base) == -1)