openmp: Fix ICE in omp_discover_declare_target_tgt_fn_r
authorJakub Jelinek <jakub@redhat.com>
Tue, 6 Oct 2020 07:25:00 +0000 (09:25 +0200)
committerJakub Jelinek <jakub@redhat.com>
Tue, 6 Oct 2020 07:25:00 +0000 (09:25 +0200)
This ICEs because node->alias_target is (not yet) a FUNCTION_DECL, but
IDENTIFIER_NODE.

I guess we should retry the discovery before LTO streaming out, the reason
to do it this early is that it can affect the gimplification and omp lowering.

2020-10-06  Jakub Jelinek  <jakub@redhat.com>

PR middle-end/97289
* omp-offload.c (omp_discover_declare_target_tgt_fn_r): Only follow
node->alias_target if it is a FUNCTION_DECL.

* c-c++-common/gomp/pr97289.c: New test.

gcc/omp-offload.c
gcc/testsuite/c-c++-common/gomp/pr97289.c [new file with mode: 0644]

index 7fb3a72ec55858a49789d21bd36867b11aaa693d..590007b943c090b7606a4e23889035c08f213a08 100644 (file)
@@ -203,7 +203,8 @@ omp_discover_declare_target_tgt_fn_r (tree *tp, int *walk_subtrees, void *data)
       symtab_node *node = symtab_node::get (*tp);
       if (node != NULL)
        {
-         while (node->alias_target)
+         while (node->alias_target
+                && TREE_CODE (node->alias_target) == FUNCTION_DECL)
            {
              if (!omp_declare_target_fn_p (node->decl)
                  && !lookup_attribute ("omp declare target host",
diff --git a/gcc/testsuite/c-c++-common/gomp/pr97289.c b/gcc/testsuite/c-c++-common/gomp/pr97289.c
new file mode 100644 (file)
index 0000000..8331b95
--- /dev/null
@@ -0,0 +1,14 @@
+/* PR middle-end/97289 */
+/* { dg-do compile } */
+/* { dg-require-weak "" } */
+/* { dg-skip-if "" { "hppa*-*-hpux*" "*-*-aix*" "nvptx-*-*" } } */
+
+void foo (void);
+static void bar (void) __attribute__ ((__weakref__ ("foo")));
+
+void
+baz (void)
+{
+#pragma omp target
+  bar ();
+}