swrast: fix undefined shift of 1 << 31
authorDave Airlie <airlied@redhat.com>
Thu, 11 Apr 2019 10:36:03 +0000 (20:36 +1000)
committerDave Airlie <airlied@redhat.com>
Thu, 11 Apr 2019 22:53:59 +0000 (08:53 +1000)
Pointed out by coverity

Reviewed-by: Eric Engestrom <eric.engestrom@intel.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
src/mesa/swrast/s_span.c

index f50b549a97fe6c8849a6bdbaf9293ed79a57a381..184a37c99b810c1459e8639e755e7cc981c155c9 100644 (file)
@@ -769,7 +769,7 @@ clip_span( struct gl_context *ctx, SWspan *span )
           * For arrays of values, shift them left.
           */
          for (i = 0; i < VARYING_SLOT_MAX; i++) {
-            if (span->interpMask & (1 << i)) {
+            if (span->interpMask & (1u << i)) {
                GLuint j;
                for (j = 0; j < 4; j++) {
                   span->attrStart[i][j] += leftClip * span->attrStepX[i][j];