freedreno/a6xx: move scissor state to stateobj

To reduce CP overhead for draws skipped in a given tile.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4813>

diff --git a/src/gallium/drivers/freedreno/a6xx/fd6_emit.c b/src/gallium/drivers/freedreno/a6xx/fd6_emit.c
index c7be485a8f2906922d514b994d01fe24fd0e86d5..4fab91c2a5183c65875965edfc1271bdfd8c5e4f 100644 (file)
--- a/src/gallium/drivers/freedreno/a6xx/fd6_emit.c
+++ b/src/gallium/drivers/freedreno/a6xx/fd6_emit.c
@@ -985,8 +985,12 @@ fd6_emit_state(struct fd_ringbuffer *ring, struct fd6_emit *emit)
                                A6XX_RB_STENCILREF_BFREF(sr->ref_value[1]));
        }
 
-       /* NOTE: scissor enabled bit is part of rasterizer state: */
-       if (dirty & (FD_DIRTY_SCISSOR | FD_DIRTY_RASTERIZER)) {
+       /* NOTE: scissor enabled bit is part of rasterizer state, but
+        * fd_rasterizer_state_bind() will mark scissor dirty if needed:
+        */
+       if (dirty & FD_DIRTY_SCISSOR) {
+               struct fd_ringbuffer *ring = fd_submit_new_ringbuffer(
+                               emit->ctx->batch->submit, 3*4, FD_RINGBUFFER_STREAMING);
                struct pipe_scissor_state *scissor = fd_context_get_scissor(ctx);
 
                OUT_PKT4(ring, REG_A6XX_GRAS_SC_SCREEN_SCISSOR_TL_0, 2);
@@ -995,6 +999,8 @@ fd6_emit_state(struct fd_ringbuffer *ring, struct fd6_emit *emit)
                OUT_RING(ring, A6XX_GRAS_SC_SCREEN_SCISSOR_TL_0_X(scissor->maxx - 1) |
                                A6XX_GRAS_SC_SCREEN_SCISSOR_TL_0_Y(scissor->maxy - 1));
 
+               fd6_emit_take_group(emit, ring, FD6_GROUP_SCISSOR, ENABLE_ALL);
+
                ctx->batch->max_scissor.minx = MIN2(ctx->batch->max_scissor.minx, scissor->minx);
                ctx->batch->max_scissor.miny = MIN2(ctx->batch->max_scissor.miny, scissor->miny);
                ctx->batch->max_scissor.maxx = MAX2(ctx->batch->max_scissor.maxx, scissor->maxx);

diff --git a/src/gallium/drivers/freedreno/a6xx/fd6_emit.h b/src/gallium/drivers/freedreno/a6xx/fd6_emit.h
index c5e8882f6a98c686150471c433247f3d4cefbb0d..d0642cb564ef3675525556b749100ae1dbbda3ef 100644 (file)
--- a/src/gallium/drivers/freedreno/a6xx/fd6_emit.h
+++ b/src/gallium/drivers/freedreno/a6xx/fd6_emit.h
@@ -63,6 +63,7 @@ enum fd6_state_id {
        FD6_GROUP_RASTERIZER,
        FD6_GROUP_ZSA,
        FD6_GROUP_BLEND,
+       FD6_GROUP_SCISSOR,
 };
 
 #define ENABLE_ALL (CP_SET_DRAW_STATE__0_BINNING | CP_SET_DRAW_STATE__0_GMEM | CP_SET_DRAW_STATE__0_SYSMEM)