Improve error message for bad arguments to script

	* generate_libstdcxx_web_docs: Improve error output.

From-SVN: r269169

diff --git a/maintainer-scripts/ChangeLog b/maintainer-scripts/ChangeLog
index 30c6f5101a73c19f2e2b39d7f1c6919423fed1d2..ced78651db37d67beccfb7daaff5d03a60015549 100644 (file)
--- a/maintainer-scripts/ChangeLog
+++ b/maintainer-scripts/ChangeLog
@@ -1,3 +1,7 @@
+2019-02-23  Jonathan Wakely  <jwakely@redhat.com>
+
+       * generate_libstdcxx_web_docs: Improve error output.
+
 2018-11-22  Martin Liska  <mliska@suse.cz>
 
        * bugzilla-close-candidate.py: New file.

diff --git a/maintainer-scripts/generate_libstdcxx_web_docs b/maintainer-scripts/generate_libstdcxx_web_docs
index 00ebcbf7f6760468f1d676314488ffd71d440509..74886356bc74f7811eb3d65f279d21bdc7e03a45 100755 (executable)
--- a/maintainer-scripts/generate_libstdcxx_web_docs
+++ b/maintainer-scripts/generate_libstdcxx_web_docs
@@ -3,16 +3,28 @@
 # i.e. http://gcc.gnu.org/onlinedocs/gcc-x.y.z/libstdc++*
 
 SRCDIR=${1}
-DOCSDIR=$(realpath ${2})
+DOCSDIR=${2}
 
 if ! [ $# -eq 2 -a -x "${SRCDIR}/configure" -a -d "${DOCSDIR}" ]
 then
+  if ! [ $# -eq 2 ]
+  then
+    echo "$0: Wrong number of arguments" >&2
+  elif ! [ -x "${SRCDIR}/configure" ]
+  then
+    echo "$0: No executable configure script found in $SRCDIR" >&2
+  elif ! [ -d "${DOCSDIR}" ]
+  then
+    echo "$0: Output directory does not exist: $DOCSDIR" >&2
+  fi
   echo "Usage: $0 <gcc src dir> <doc output dir>" >&2
   exit 1
 fi
 
 set -e
 
+DOCSDIR=$(realpath ${DOCSDIR})
+
 # Check we have some of the required tools
 for i in doxygen dot dblatex pdflatex makeindex
 do