remote-stdio-gdbserver: Pass "target" to remote_exec to delete file
authorSimon Marchi <simon.marchi@ericsson.com>
Thu, 8 Mar 2018 22:54:25 +0000 (17:54 -0500)
committerSimon Marchi <simon.marchi@ericsson.com>
Thu, 8 Mar 2018 22:54:54 +0000 (17:54 -0500)
As described here

  https://sourceware.org/bugzilla/show_bug.cgi?id=22841

there seems to be situations where the remote-stdio-gdbserver board
fails to delete the uploaded binary file.  Passing "target" fixes the
issue for Christian who reported the bug.

I did not experience this problem, but passing "target" to remote_exec
still works for me, so I'm fine with changing it.

Any objection?

gdb/testsuite/ChangeLog:

PR gdb/22841
* boards/remote-stdio-gdbserver.exp (${board}_file): Pass
"target" to remote_exec.

gdb/testsuite/ChangeLog
gdb/testsuite/boards/remote-stdio-gdbserver.exp

index 1aeb785131ad24ab7496c25040a86ac133cb2ab4..c24ae5fb20a5ebf405d246c2e1df8a267b2e50eb 100644 (file)
@@ -1,3 +1,9 @@
+2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
+
+       PR gdb/22841
+       * boards/remote-stdio-gdbserver.exp (${board}_file): Pass
+       "target" to remote_exec.
+
 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
 
        PR gdb/22841
index aff7902f438f7b8f79bc560dafabb344cfc39c1c..d559b85313d1ecab6cce01a5522c54cda438da0a 100644 (file)
@@ -75,7 +75,7 @@ proc get_target_remote_pipe_cmd { } {
 
 proc ${board}_file { dest op args } {
     if { $op == "delete" } {
-       return [remote_exec [get_remote_login] "rm -f $args"]
+       return [remote_exec target "rm -f $args"]
     }
     return [eval [list standard_file $dest $op] $args]
 }