Make "all" depend on "info"

I've broken "make info" a couple of times now, because I sometimes
forget to run "make info" after modifying a Texinfo file.

I don't know why gdb's "make all" doesn't build the info pages.  I
suspect this was some Cygnus-local oddity back in the day.

This patch changes doc/Makefile.in so that the info pages are built by
"make all".  As a point of reference, Automake has essentially always
worked this way.  According to the Automake manual (I didn't
double-check) this is required by the GNU coding standards.

The first time I sent this patch, I mentioned that I wanted to look
into some existing bugs in bugzilla about missing "makeinfo".
However, today I tried and I discovered that BFD requires makeinfo,
and builds its info file as part of "all".  So, I think this change
doesn't worsen the situation for users in any way, and can simply go
in.

gdb/doc/ChangeLog
2019-04-07  Tom Tromey  <tom@tromey.com>

	* Makefile.in (all): Depend on "info".

diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index ea5fafdff1a0b15f146a7e1ec0fcd451932564a2..5a0621e2ceb5c46fae170bf602c8c85cfc53752d 100644 (file)
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,3 +1,7 @@
+2019-04-07  Tom Tromey  <tom@tromey.com>
+
+       * Makefile.in (all): Depend on "info".
+
 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 
        * gdb.texinfo (Convenience Funs): Document '$_creal' and

diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in
index 39c94dc82bcca27ac13231345f8cb68899a06911..2bb8a3051bb92f25f2721e20b5a00a7fdd3fd71d 100644 (file)
--- a/gdb/doc/Makefile.in
+++ b/gdb/doc/Makefile.in
@@ -182,7 +182,7 @@ HAVE_NATIVE_GCORE_TARGET = @HAVE_NATIVE_GCORE_TARGET@
 
 ###
 
-all:
+all: info
 
 info: $(INFO_DEPS)
 dvi: gdb.dvi stabs.dvi refcard.dvi annotate.dvi