gallium: comments about mipmap gen
authorBrian <brian.paul@tungstengraphics.com>
Mon, 11 Feb 2008 16:50:21 +0000 (09:50 -0700)
committerBen Skeggs <skeggsb@gmail.com>
Fri, 15 Feb 2008 02:51:11 +0000 (13:51 +1100)
src/mesa/state_tracker/st_gen_mipmap.c

index 5c00392af7c4302761550e3b03d8a136b6a0505a..f6af37cfac3c2999dc5423787c65bb5f701fd9eb 100644 (file)
@@ -273,6 +273,10 @@ st_render_mipmap(struct st_context *st,
    pipe->bind_fs_state(pipe, stfp->fs->data);
    pipe->bind_vs_state(pipe, stvp->cso->data);
 
+   /*
+    * XXX for small mipmap levels, it may be faster to use the software
+    * fallback path...
+    */
    for (dstLevel = baseLevel + 1; dstLevel <= lastLevel; dstLevel++) {
       const uint srcLevel = dstLevel - 1;
 
@@ -348,6 +352,7 @@ fallback_generate_mipmap(GLcontext *ctx, GLenum target,
                                          PIPE_BUFFER_USAGE_CPU_WRITE)
               + dstSurf->offset;
 
+      /* XXX need to take stride/pitch info into account... */
       _mesa_generate_mipmap_level(target, datatype, comps,
                    0 /*border*/,
                    pt->width[srcLevel], pt->height[srcLevel], pt->depth[srcLevel],