re PR middle-end/17526 (libcpp is miscompiled with -fno-pcc-struct-return -O2)

        PR middle-end/17526
        * tree-gimple.c (is_gimple_mem_rhs): Also require a val for
        aggregate types that are not BLKmode.

From-SVN: r89915

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 8fd5efb79f49fb2e391d27773d7bc2a44164e2d6..50f6cb269b1966073191584c43566e4cab1fc130 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2004-10-31  Jason Merrill  <jason@redhat.com>
+
+       PR middle-end/17526
+       * tree-gimple.c (is_gimple_mem_rhs): Also require a val for
+       aggregate types that are not BLKmode.
+
 2004-10-30  Ziemowit Laski  <zlaski@apple.com>
 
        * c-common.h (objc_lookup_ivar): Add second parameter to

diff --git a/gcc/tree-gimple.c b/gcc/tree-gimple.c
index 84005aad4095b78a2a800c547636f3e981decc27..4a31c0ee98cf67d5dd13c237b2c8dacb1213befc 100644 (file)
--- a/gcc/tree-gimple.c
+++ b/gcc/tree-gimple.c
@@ -111,9 +111,12 @@ is_gimple_reg_rhs (tree t)
 bool
 is_gimple_mem_rhs (tree t)
 {
-  /* If we're dealing with a renamable type, either source or dest
-     must be a renamed variable.  */
-  if (is_gimple_reg_type (TREE_TYPE (t)))
+  /* If we're dealing with a renamable type, either source or dest must be
+     a renamed variable.  Also force a temporary if the type doesn't need
+     to be stored in memory, since it's cheap and prevents erroneous
+     tailcalls (PR 17526).  */
+  if (is_gimple_reg_type (TREE_TYPE (t))
+      || TYPE_MODE (TREE_TYPE (t)) != BLKmode)
     return is_gimple_val (t);
   else
     return is_gimple_formal_tmp_rhs (t);