LWG 3040: define starts_with/ends_with as proposed

	* include/std/string_view [__cplusplus > 201703L]
	(basic_string_view::starts_with(basic_string_view)): Implement
	proposed resolution of LWG 3040 to avoid redundant length check.
	(basic_string_view::starts_with(_CharT)): Implement proposed
	resolution of LWG 3040 to check at most one character.
	(basic_string_view::ends_with(_CharT)): Likewise.

From-SVN: r267234

diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog
index d9dc973a440628e38441b5cf84a993165a8efe1f..e25b9ce8f79d2ffa93ef1da02674da1140f779b0 100644 (file)
--- a/libstdc++-v3/ChangeLog
+++ b/libstdc++-v3/ChangeLog
@@ -1,3 +1,12 @@
+2018-12-18  Jonathan Wakely  <jwakely@redhat.com>
+
+       * include/std/string_view [__cplusplus > 201703L]
+       (basic_string_view::starts_with(basic_string_view)): Implement
+       proposed resolution of LWG 3040 to avoid redundant length check.
+       (basic_string_view::starts_with(_CharT)): Implement proposed
+       resolution of LWG 3040 to check at most one character.
+       (basic_string_view::ends_with(_CharT)): Likewise.
+
 2018-12-17  Jonathan Wakely  <jwakely@redhat.com>
 
        PR libstdc++/71044

diff --git a/libstdc++-v3/include/std/string_view b/libstdc++-v3/include/std/string_view
index 28d3fa46718ff8a688a3b022284d551b837787c1..ac84b24314e10909e89715c5dc4b14e7f05bce11 100644 (file)
--- a/libstdc++-v3/include/std/string_view
+++ b/libstdc++-v3/include/std/string_view
@@ -389,14 +389,11 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
 #if __cplusplus > 201703L
       constexpr bool
       starts_with(basic_string_view __x) const noexcept
-      {
-       return this->size() >= __x.size()
-           && this->compare(0, __x.size(), __x) == 0;
-      }
+      { return this->substr(0, __x.size()) == __x; }
 
       constexpr bool
       starts_with(_CharT __x) const noexcept
-      { return this->starts_with(basic_string_view(&__x, 1)); }
+      { return !this->empty() && traits_type::eq(this->front(), __x); }
 
       constexpr bool
       starts_with(const _CharT* __x) const noexcept
@@ -411,7 +408,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
 
       constexpr bool
       ends_with(_CharT __x) const noexcept
-      { return this->ends_with(basic_string_view(&__x, 1)); }
+      { return !this->empty() && traits_type::eq(this->back(), __x); }
 
       constexpr bool
       ends_with(const _CharT* __x) const noexcept