projects
/
mesa.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
1171f17
)
broadcom/vc5: Fix a typo in memcmp for sig unpack checking.
author
Eric Anholt
<eric@anholt.net>
Thu, 14 Dec 2017 17:41:16 +0000
(09:41 -0800)
committer
Eric Anholt
<eric@anholt.net>
Thu, 14 Dec 2017 22:36:24 +0000
(14:36 -0800)
This shockingly ended up working out, because only the first byte of *sig
is used and (sizeof(*sig) != 0) == 1. Fixes a compiler warning.
Link:
https://bugs.freedesktop.org/show_bug.cgi?id=104183
src/broadcom/qpu/qpu_pack.c
patch
|
blob
|
history
diff --git
a/src/broadcom/qpu/qpu_pack.c
b/src/broadcom/qpu/qpu_pack.c
index 0ecce86662a33cab95a00a6f98b2097003668614..6630ed4b85fea079c12cd3ef63ba29b521e0945d 100644
(file)
--- a/
src/broadcom/qpu/qpu_pack.c
+++ b/
src/broadcom/qpu/qpu_pack.c
@@
-168,7
+168,7
@@
v3d_qpu_sig_unpack(const struct v3d_device_info *devinfo,
/* Signals with zeroed unpacked contents after element 0 are reserved. */
return (packed_sig == 0 ||
- memcmp(sig, &v33_sig_map[0], sizeof(*sig)
!= 0)
);
+ memcmp(sig, &v33_sig_map[0], sizeof(*sig)
) != 0
);
}
bool