zink: delete query rather than allocating a new one
authorErik Faye-Lund <erik.faye-lund@collabora.com>
Wed, 27 Nov 2019 15:30:29 +0000 (16:30 +0100)
committerErik Faye-Lund <erik.faye-lund@collabora.com>
Fri, 29 Nov 2019 08:54:25 +0000 (09:54 +0100)
It seems I had some fat fingers when writing this function, and I
accidentally ended up allocating a new query and immediately trying to
delete an uninitialized pool instead of just deleting the pool of the
query that was passed.

CoverityID: 1455196
Reviewed-by: Dave Airlie <airlied@redhat.com>
src/gallium/drivers/zink/zink_query.c

index 615bd2b936853bc44f0daa55160072c6f1ba7d9b..e8ed72a1da51f7802a57dc14944c5bc06b1002d0 100644 (file)
@@ -80,7 +80,7 @@ zink_destroy_query(struct pipe_context *pctx,
                    struct pipe_query *q)
 {
    struct zink_screen *screen = zink_screen(pctx->screen);
-   struct zink_query *query = CALLOC_STRUCT(zink_query);
+   struct zink_query *query = (struct zink_query *)q;
 
    vkDestroyQueryPool(screen->dev, query->query_pool, NULL);
 }