panfrost: Don't set shared->unk0
authorAlyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tue, 25 Feb 2020 20:32:23 +0000 (15:32 -0500)
committerTomeu Vizoso <tomeu.vizoso@collabora.com>
Thu, 27 Feb 2020 15:31:54 +0000 (16:31 +0100)
This field controls the size of per-thread temporaries (somehow this is
separate from the regular stack for register spilling..), though I'm not
certain on the details. Regardless this value of 0x1e despite being used
in places by the blob seems wrong and is interfering with correct sizing
of the stack.

We don't use non-spilling scratchpad yet, so this is just here to fix
some details of spilling.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3950>

src/gallium/drivers/panfrost/pan_mfbd.c

index 799fac140847fe1386628849b8d6dd4a9dba943a..f150278bd7bff7bd745421bd94e82201afca2d0f 100644 (file)
@@ -380,7 +380,6 @@ panfrost_emit_mfbd(struct panfrost_batch *batch, unsigned vertex_count)
                 .tiler = panfrost_emit_midg_tiler(batch, vertex_count),
 
                 .shared_memory = {
-                        .unk0 = 0x1e,
                         .stack_shift = shift,
                         .scratchpad = panfrost_batch_get_scratchpad(batch, shift, screen->thread_tls_alloc, screen->core_count)->gpu,
                         .shared_workgroup_count = ~0,