Fix potential illegal memory access in AVR backend.

	* elf32-avr.c (avr_stub_name): Check for a NULL return from
	bfd_malloc.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 117a8dbdcaca124f6bcaa857b5633ef44f2a2cad..59b72666873b92b7da8fdbd5da0247bffeaa76fe 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2018-08-01  Nick Clifton  <nickc@redhat.com>
+
+       * elf32-avr.c (avr_stub_name): Check for a NULL return from
+       bfd_malloc.
+
 2018-08-01  Zenith  <zenith432@users.sourceforge.net>
 
        PR 23460

diff --git a/bfd/elf32-avr.c b/bfd/elf32-avr.c
index 7087606c935041836bda6aea226166372e22a717..6d38d1db3af2689faaffb16947a04d7f0406732b 100644 (file)
--- a/bfd/elf32-avr.c
+++ b/bfd/elf32-avr.c
@@ -3295,10 +3295,10 @@ avr_stub_name (const asection *symbol_section,
 
   len = 8 + 1 + 8 + 1 + 1;
   stub_name = bfd_malloc (len);
-
-  sprintf (stub_name, "%08x+%08x",
-          symbol_section->id & 0xffffffff,
-          (unsigned int) ((rela->r_addend & 0xffffffff) + symbol_offset));
+  if (stub_name != NULL)
+    sprintf (stub_name, "%08x+%08x",
+            symbol_section->id & 0xffffffff,
+            (unsigned int) ((rela->r_addend & 0xffffffff) + symbol_offset));
 
   return stub_name;
 }