re PR tree-optimization/66423 (a % (1 << b) no longer gets folded to a & (1 << b...

2015-06-09  Richard Biener  <rguenther@suse.de>

	PR middle-end/66423
	* match.pd: Handle A % (unsigned)(1 << B).

	* gcc.dg/fold-modpow2.c: New testcase.

From-SVN: r224279

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 7adf74a3a1df114859fbc35eacf15dfdb73e7ad7..4ad4d66bb43b58b9109af60ca3264a9aa8d719e8 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2015-06-09  Richard Biener  <rguenther@suse.de>
+
+       PR middle-end/66423
+       * match.pd: Handle A % (unsigned)(1 << B).
+
 2015-06-09  Aldy Hernandez  <aldyh@redhat.com>
 
        * varasm.c (output_object_block_htab): Remove.

diff --git a/gcc/match.pd b/gcc/match.pd
index abd785178fc0f7795284559e4b6a8d5f4607adc6..48a304703a09494384f59bbe80735ebb1a0e8026 100644 (file)
--- a/gcc/match.pd
+++ b/gcc/match.pd
@@ -248,11 +248,12 @@ along with GCC; see the file COPYING3.  If not see
  (lshift INTEGER_CST@1 @2))
 (for mod (trunc_mod floor_mod)
  (simplify
-  (mod @0 (power_of_two_cand@1 @2))
+  (mod @0 (convert?@3 (power_of_two_cand@1 @2)))
   (if ((TYPE_UNSIGNED (type)
        || tree_expr_nonnegative_p (@0))
+       && tree_nop_conversion_p (type, TREE_TYPE (@3))
        && integer_pow2p (@2) && tree_int_cst_sgn (@2) > 0)
-   (bit_and @0 (minus @1 { build_int_cst (TREE_TYPE (@1), 1); })))))
+   (bit_and @0 (convert (minus @1 { build_int_cst (TREE_TYPE (@1), 1); }))))))
 
 /* X % Y is smaller than Y.  */
 (for cmp (lt ge)

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 80fba49c3de5d8c2eeb02a0bed9b923e3a7b160b..5b5c718cd4055bf55f808dce2ec8a35493790fa9 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2015-06-09  Richard Biener  <rguenther@suse.de>
+
+       PR middle-end/66423
+       * gcc.dg/fold-modpow2.c: New testcase.
+
 2015-06-09  Richard Biener  <rguenther@suse.de>
 
        PR tree-optimization/66419

diff --git a/gcc/testsuite/gcc.dg/fold-modpow2.c b/gcc/testsuite/gcc.dg/fold-modpow2.c
new file mode 100644 (file)
index 0000000..4541b1c
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/fold-modpow2.c
@@ -0,0 +1,11 @@
+/* { dg-do compile } */
+/* { dg-options "-fdump-tree-original" } */
+
+unsigned int
+my_mod (unsigned int a, unsigned int b)
+{
+  return a % (1 << b);
+}
+
+/* The above should be simplified to (unsigned int) ((1 << b) + -1) & a */
+/* { dg-final { scan-tree-dump "& a;" "original" } } */