PR c++/81169 - -Wclass-memaccess illegitimate warning related to volatile

gcc/cp/ChangeLog:

	PR c++/81169
	* call.c (maybe_warn_class_memaccess): Preserve explicit conversions
	to detect casting away cv-qualifiers.

gcc/testsuite/ChangeLog:

	PR c++/81169
	* g++.dg/Wclass-memaccess-2.C: New test.

From-SVN: r249660

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 040f7b79cc4af3a43f1a0d987c180e4fe6987677..8bc268c1dcd4af9300aba7e7f4342a6f6f1b735a 100644 (file)
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,9 @@
+2017-06-26  Martin Sebor  <msebor@redhat.com>
+
+       PR c++/81169
+       * call.c (maybe_warn_class_memaccess): Preserve explicit conversions
+       to detect casting away cv-qualifiers.
+
 2017-06-26  Nathan Sidwell  <nathan@acm.org>
 
        * cp-tree.h (lang_decl_fn): Remove assignment_operator_p field.

diff --git a/gcc/cp/call.c b/gcc/cp/call.c
index f480611a990b00684bd68371972bfb293086cd71..ff0a26b93350f3a6d0c3ec8cc30fec836adfeccd 100644 (file)
--- a/gcc/cp/call.c
+++ b/gcc/cp/call.c
@@ -8340,7 +8340,10 @@ maybe_warn_class_memaccess (location_t loc, tree fndecl, tree *args)
   if (!dest || !TREE_TYPE (dest) || !POINTER_TYPE_P (TREE_TYPE (dest)))
     return;
 
-  STRIP_NOPS (dest);
+  /* Remove the outermost (usually implicit) conversion to the void*
+     argument type.  */
+  if (TREE_CODE (dest) == NOP_EXPR)
+    dest = TREE_OPERAND (dest, 0);
 
   tree srctype = NULL_TREE;
 
@@ -8357,7 +8360,7 @@ maybe_warn_class_memaccess (location_t loc, tree fndecl, tree *args)
   if (current_function_decl
       && (DECL_CONSTRUCTOR_P (current_function_decl)
          || DECL_DESTRUCTOR_P (current_function_decl))
-      && is_this_parameter (dest))
+      && is_this_parameter (tree_strip_nop_conversions (dest)))
     {
       tree ctx = DECL_CONTEXT (current_function_decl);
       bool special = same_type_ignoring_top_level_qualifiers_p (ctx, desttype);

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 8b1d5af941d53f78f68b66d97f4f12ddc0ae8e16..d7c906aad6f59eb409eca43113c7d90e10b8a0f0 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2017-06-26  Martin Sebor  <msebor@redhat.com>
+
+       PR c++/81169
+       * g++.dg/Wclass-memaccess-2.C: New test.
+
 2017-06-26  Carl Love  <cel@us.ibm.com>
 
        * gcc.target/powerpc/builtins-3-vec_reve-runnable.c:

diff --git a/gcc/testsuite/g++.dg/Wclass-memaccess-2.C b/gcc/testsuite/g++.dg/Wclass-memaccess-2.C
new file mode 100644 (file)
index 0000000..49581df
--- /dev/null
+++ b/gcc/testsuite/g++.dg/Wclass-memaccess-2.C
@@ -0,0 +1,61 @@
+// PR c++/81169 - -Wclass-memaccess illegitimate warning related to volatile
+// { dg-do compile }
+// { dg-options "-Wclass-memaccess" }
+
+struct S { int x; };
+
+void cast_const (const S *p)
+{
+  __builtin_memset (const_cast<S*>(p), 0, sizeof *p);
+}
+
+void cast_volatile (volatile S *p)
+{
+  __builtin_memset (const_cast<S*>(p), 0, sizeof *p);
+}
+
+void cast_const_volatile (const volatile S *p)
+{
+  __builtin_memset (const_cast<S*>(p), 0, sizeof *p);
+}
+
+void c_cast_const_volatile (const volatile S *p)
+{
+  __builtin_memset ((S*)p, 0, sizeof *p);
+}
+
+// A C cast to void* suppresses the warning because it casts away
+// the qualifiers from the otherwise trivial pointed-to type..
+void c_void_cast_const_volatile (const volatile S *p)
+{
+  __builtin_memset ((void*)p, 0, sizeof *p);
+}
+
+// Also verify that casting to char* suppresses the warning for
+// non-trivial types.
+
+struct NonTrivial
+{
+  NonTrivial ();
+  NonTrivial (const NonTrivial&);
+  NonTrivial& operator= (const NonTrivial&);
+  ~NonTrivial ();
+};
+
+void cast_void (NonTrivial *p)
+{
+  __builtin_memset (reinterpret_cast<char*>(p), 0, sizeof *p);
+}
+
+// A C cast to a character (or any trivial) type suppresses the warning.
+void c_cast_uchar (NonTrivial *p)
+{
+  __builtin_memset ((unsigned char*)p, 0, sizeof *p);
+}
+
+// A cast to void* does not suppress the warning.  That is (or can be)
+// considered a feature.
+void c_cast_void (NonTrivial *p)
+{
+  __builtin_memset ((void*)p, 0, sizeof *p);   // { dg-warning "\\\[-Wclass-memaccess]" }
+}