compile: Fix function pointers

TBH while I always comment reasons for each of the compilation options in
reality I tried them all and chose that combination that needs the most simple
compile/compile-object-load.c (ld.so emulation) implementation.

gdb/ChangeLog
2015-01-22  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* compile/compile.c (_initialize_compile): Use -fPIE for compile_args.

gdb/testsuite/ChangeLog
2015-01-22  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.compile/compile.exp (pointer to jit function): New test.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 06be4ed30c404af4ad679fb445388939b282da64..fecedeb6251f1a4151e68995d829193d8a334033 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2015-01-22  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+       * compile/compile.c (_initialize_compile): Use -fPIE for compile_args.
+
 2015-01-22  Eli Zaretskii  <eliz@gnu.org>
 
        * Makefile.in (HFILES_NO_SRCDIR): Remove ada-varobj.h.

diff --git a/gdb/compile/compile.c b/gdb/compile/compile.c
index ccac49dd1729bd5b4bf8c5f3ec6fd8e583dd177b..70b6d44cd20b2a6b5205e2293e09f2ea47828963 100644 (file)
--- a/gdb/compile/compile.c
+++ b/gdb/compile/compile.c
@@ -645,12 +645,13 @@ String quoting is parsed like in shell, for example:\n\
 
   /* Override flags possibly coming from DW_AT_producer.  */
   compile_args = xstrdup ("-O0 -gdwarf-4"
-  /* We use -fPIC Otherwise GDB would need to reserve space large enough for
+  /* We use -fPIE Otherwise GDB would need to reserve space large enough for
      any object file in the inferior in advance to get the final address when
      to link the object file to and additionally the default system linker
      script would need to be modified so that one can specify there the
-     absolute target address.  */
-                        " -fPIC"
+     absolute target address.
+     -fPIC is not used at is would require from GDB to generate .got.  */
+                        " -fPIE"
   /* We don't want warnings.  */
                         " -w"
   /* Override CU's possible -fstack-protector-strong.  */

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 9dd10f070f088ef7b4458efb817442a2c9cdd9fb..b01a4c9eb32fef7bbaacf6154fd32ba3a9fdcef0 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2015-01-22  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+       * gdb.compile/compile.exp (pointer to jit function): New test.
+
 2015-01-17  Wei-cheng Wang  <cole945@gmail.com>
 
        * lib/gdb.exp (supports_process_record): Return true for

diff --git a/gdb/testsuite/gdb.compile/compile.exp b/gdb/testsuite/gdb.compile/compile.exp
index e426cc116e0293b41e50d0c43cb306c712564d43..dc09770133a8c3ad95661806fa9d318f9616a906 100644 (file)
--- a/gdb/testsuite/gdb.compile/compile.exp
+++ b/gdb/testsuite/gdb.compile/compile.exp
@@ -259,6 +259,11 @@ gdb_test_no_output "end" "compile code -r multiline 4"
 gdb_test "print 'compile.c'::globalshadow" " = 77000" \
     "check globalshadow with -r"
 
+# Test GOT vs. resolving jit function pointers.
+
+gdb_test_no_output "compile -raw -- int func(){return 21;} _gdb_expr(){int (*funcp)()=func; if (funcp()!=21) abort();}" \
+    "pointer to jit function"
+
 #
 # Test the case where the registers structure would not normally have
 # any fields.