Fix PR70182 -- missing "on" in mangling of unresolved operators

The ABI says:

<unresolved-name>
   ::= [gs] <base-unresolved-name>
   ::= sr <unresolved-type> <base-unresolved-name>
   ::= srN <unresolved-type> <unresolved-qualifier-level>+ E <base-unresolved-name>
   ::= [gs] sr <unresolved-qualifier-level>+ E <base-unresolved-name>

<base-unresolved-name>
   ::= <simple-id>
   ::= on <operator-name>
   ::= on <operator-name> <template-args>
   ::= dn <destructor-name

libiberty:

	PR c++/70182
	* cp-demangle.c (d_unqualified_name): Handle "on" for
	operator names.
	* testsuite/demangle-expected: Add tests.

gcc/cp:

	PR c++/70182
	* mangle.c (write_template_args): Add "on" for operator names.

gcc:

	PR c++/70182
	* doc/invoke.texi (fabi-version): Mention mangling fix for
	operator names.

From-SVN: r244567

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 13a7015ccc274340ee7e46c316b03eb3d91b0703..257a21d30cfaa4690dfacaf9756fcf0cf50f6b76 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2017-01-18  Markus Trippelsdorf  <markus@trippelsdorf.de>
+
+       PR c++/70182
+       * doc/invoke.texi (fabi-version): Mention mangling fix for
+       operator names.
+
 2017-01-18  Markus Trippelsdorf  <markus@trippelsdorf.de>
 
        PR c++/77489

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 86669ae13710742ee44d105d03fdf4fee80d6b15..a42454a478a12afb21ff3825784d8cf0e2f42a70 100644 (file)
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,8 @@
+2017-01-18  Markus Trippelsdorf  <markus@trippelsdorf.de>
+
+       PR c++/70182
+       * mangle.c (write_template_args): Add "on" for operator names.
+
 2017-01-18  Markus Trippelsdorf  <markus@trippelsdorf.de>
 
        PR c++/77489

diff --git a/gcc/cp/mangle.c b/gcc/cp/mangle.c
index 67ec5c31f170f4eeb6ce84cac36a6d0c5e2aed21..d1b107cbb1d46d505ce4f13d44e83ac0fc562dce 100644 (file)
--- a/gcc/cp/mangle.c
+++ b/gcc/cp/mangle.c
@@ -2817,6 +2817,12 @@ write_template_args (tree args)
 static void
 write_member_name (tree member)
 {
+  if (abi_version_at_least (11) && IDENTIFIER_OPNAME_P (member))
+    {
+      write_string ("on");
+      if (abi_warn_or_compat_version_crosses (11))
+       G.need_abi_warning = 1;
+    }
   if (identifier_p (member))
     write_unqualified_id (member);
   else if (DECL_P (member))

diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 767c8f42fee9409754cd6cdfe2439eae8fcb8de9..06e3ae866648552813f621ea7a02b0d870285b2d 100644 (file)
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -2252,10 +2252,10 @@ attributes that affect type identity, such as ia32 calling convention
 attributes (e.g. @samp{stdcall}).
 
 Version 11, which first appeared in G++ 7, corrects the mangling of
-sizeof... expressions.  For multiple entities with the same name within
-a function, that are declared in different scopes, the mangling now
-changes starting with the eighth occurence.  It also implies
-@option{-fnew-inheriting-ctors}.
+sizeof... expressions and operator names.  For multiple entities with
+the same name within a function, that are declared in different scopes,
+the mangling now changes starting with the eighth occurence.  It also
+implies @option{-fnew-inheriting-ctors}.
 
 See also @option{-Wabi}.
 

diff --git a/gcc/testsuite/g++.dg/abi/mangle13.C b/gcc/testsuite/g++.dg/abi/mangle13.C
index 716c4c36f410901dc2620ea5a317f84feca18fe2..c8822a34039ccbb34b30129fe7e334562c5ad7f0 100644 (file)
--- a/gcc/testsuite/g++.dg/abi/mangle13.C
+++ b/gcc/testsuite/g++.dg/abi/mangle13.C
@@ -1,4 +1,4 @@
-// { dg-options "-fabi-version=0" }
+// { dg-options "-fabi-version=10" }
 
 struct A {
   template <typename T> int f ();

diff --git a/gcc/testsuite/g++.dg/abi/mangle37.C b/gcc/testsuite/g++.dg/abi/mangle37.C
index 691566b384ba519839e74edc6de5ecff790cb003..4dd87e84c108b4b0fde520e0fa8a6decaa2ac46e 100644 (file)
--- a/gcc/testsuite/g++.dg/abi/mangle37.C
+++ b/gcc/testsuite/g++.dg/abi/mangle37.C
@@ -1,5 +1,6 @@
 // Testcase for mangling of expressions involving operator names.
 // { dg-do compile { target c++11 } }
+// { dg-options "-fabi-version=10" }
 // { dg-final { scan-assembler "_Z1fI1AEDTclonplfp_fp_EET_" } }
 // { dg-final { scan-assembler "_Z1gI1AEDTclonplIT_Efp_fp_EES1_" } }
 // { dg-final { scan-assembler "_Z1hI1AEDTcldtfp_miEET_" } }

diff --git a/gcc/testsuite/g++.dg/abi/pr70182.C b/gcc/testsuite/g++.dg/abi/pr70182.C
new file mode 100644 (file)
index 0000000..d299362
--- /dev/null
+++ b/gcc/testsuite/g++.dg/abi/pr70182.C
@@ -0,0 +1,28 @@
+// { dg-options "-fabi-version=0" }
+
+struct A {
+  template <typename T> int f ();
+  int operator+();
+  operator int ();
+  template <typename T> 
+  int operator-();
+};
+
+typedef int (A::*P)();
+
+template <P> struct S {};
+
+template <typename T> void g (S<&T::template f<int> >) {}
+template <typename T> void g (S<&T::operator+ >) {}
+template <typename T> void g (S<&T::operator int>) {}
+template <typename T> void g (S<&T::template operator- <double> >) {}
+
+template void g<A> (S<&A::f<int> >);
+template void g<A> (S<&A::operator+>);
+template void g<A> (S<&A::operator int>);
+template void g<A> (S<&A::operator-<double> >);
+
+// { dg-final { scan-assembler _Z1gI1AEv1SIXadsrT_1fIiEEE } }
+// { dg-final { scan-assembler _Z1gI1AEv1SIXadsrT_onplEE } }
+// { dg-final { scan-assembler _Z1gI1AEv1SIXadsrT_oncviEE } }
+// { dg-final { scan-assembler _Z1gI1AEv1SIXadsrT_onmiIdEEE } }

diff --git a/gcc/testsuite/g++.dg/dfp/mangle-1.C b/gcc/testsuite/g++.dg/dfp/mangle-1.C
index 455d3e4c0ef6ccde15d56666d2618e8ef5ee0411..ee9644b27a5364dda5bd7fffd234550bd331b3c2 100644 (file)
--- a/gcc/testsuite/g++.dg/dfp/mangle-1.C
+++ b/gcc/testsuite/g++.dg/dfp/mangle-1.C
@@ -1,4 +1,5 @@
 // { dg-do compile }
+// { dg-options "-fabi-version=10" }
 
 // Mangling of classes from std::decimal are special-cased.
 // Derived from g++.dg/abi/mangle13.C.

diff --git a/libiberty/ChangeLog b/libiberty/ChangeLog
index 104907c84c8613ded82659fc38ce85cd9efbcae4..0c5972a184427c302c0dab3720182b8c54b9e0ab 100644 (file)
--- a/libiberty/ChangeLog
+++ b/libiberty/ChangeLog
@@ -1,3 +1,10 @@
+2017-01-18  Markus Trippelsdorf  <markus@trippelsdorf.de>
+
+       PR PR c++/70182
+       * cp-demangle.c (d_unqualified_name): Handle "on" for
+       operator names.
+       * testsuite/demangle-expected: Add tests.
+
 2017-01-18  Markus Trippelsdorf  <markus@trippelsdorf.de>
 
        PR c++/77489

diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c
index d84929eca20ddd052fa243e09342ecfb547df090..f0dbf9381c6becf02c89fc3df0dbd24bb71d7e9b 100644 (file)
--- a/libiberty/cp-demangle.c
+++ b/libiberty/cp-demangle.c
@@ -1594,6 +1594,8 @@ d_unqualified_name (struct d_info *di)
     ret = d_source_name (di);
   else if (IS_LOWER (peek))
     {
+      if (peek == 'o' && d_peek_next_char (di) == 'n')
+       d_advance (di, 2);
       ret = d_operator_name (di);
       if (ret != NULL && ret->type == DEMANGLE_COMPONENT_OPERATOR)
        {

diff --git a/libiberty/testsuite/demangle-expected b/libiberty/testsuite/demangle-expected
index 07e258fe58b36fc2b82f81fe397a56da5002601b..c1cfa1545ecaf8c945211b7d7b4088d9ea05e075 100644 (file)
--- a/libiberty/testsuite/demangle-expected
+++ b/libiberty/testsuite/demangle-expected
@@ -4682,3 +4682,10 @@ _ZZ3foovE8localVar__9_
 
 _ZZ3foovE8localVar__12
 _ZZ3foovE8localVar__12
+
+# PR 70182
+_Z1gI1AEv1SIXadsrT_onplEE
+void g<A>(S<&A::operator+>)
+
+_Z1gI1AEv1SIXadsrT_plEE
+void g<A>(S<&A::operator+>)