PR c/70281: C FE: fix uninitialized range for __builtin_types_compatible_p

gcc/c/ChangeLog:
	PR c/70281
	* c-parser.c (c_parser_postfix_expression): Set the source range
	for uses of "__builtin_types_compatible_p".

gcc/testsuite/ChangeLog:
	PR c/70281
	* gcc.dg/plugin/diagnostic-test-expressions-1.c
	(test_builtin_types_compatible_p): New test function.
	* gcc.dg/pr70281.c: New test case.

From-SVN: r234340

diff --git a/gcc/c/ChangeLog b/gcc/c/ChangeLog
index 3d57c76cd5817fe717ae9819280e172bdd2dc069..c8cb0227e2a35f9ec319f147109f99fac3a2c559 100644 (file)
--- a/gcc/c/ChangeLog
+++ b/gcc/c/ChangeLog
@@ -1,3 +1,9 @@
+2016-03-18  David Malcolm  <dmalcolm@redhat.com>
+
+       PR c/70281
+       * c-parser.c (c_parser_postfix_expression): Set the source range
+       for uses of "__builtin_types_compatible_p".
+
 2016-03-17  Jakub Jelinek  <jakub@redhat.com>
 
        PR c/70280

diff --git a/gcc/c/c-parser.c b/gcc/c/c-parser.c
index 82d6eca06fc3ae8487bc24f8e6da30728dd39cfb..646068424bd2330012aa51ef0f7d3e7e7a8383b1 100644 (file)
--- a/gcc/c/c-parser.c
+++ b/gcc/c/c-parser.c
@@ -7782,9 +7782,10 @@ c_parser_postfix_expression (c_parser *parser)
              expr.value = error_mark_node;
              break;
            }
-         c_parser_skip_until_found (parser, CPP_CLOSE_PAREN,
-                                    "expected %<)%>");
          {
+           location_t close_paren_loc = c_parser_peek_token (parser)->location;
+           c_parser_skip_until_found (parser, CPP_CLOSE_PAREN,
+                                      "expected %<)%>");
            tree e1, e2;
            e1 = groktypename (t1, NULL, NULL);
            e2 = groktypename (t2, NULL, NULL);
@@ -7799,6 +7800,7 @@ c_parser_postfix_expression (c_parser *parser)
 
            expr.value
              = comptypes (e1, e2) ? integer_one_node : integer_zero_node;
+           set_c_expr_source_range (&expr, loc, close_paren_loc);
          }
          break;
        case RID_BUILTIN_CALL_WITH_STATIC_CHAIN:

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 4c8b3d17f76d7128a74c3072018a38f3580aadaf..c3ceedbd88ed6ffcd78ab0dc9bd9eb7a91261c5c 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,10 @@
+2016-03-18  David Malcolm  <dmalcolm@redhat.com>
+
+       PR c/70281
+       * gcc.dg/plugin/diagnostic-test-expressions-1.c
+       (test_builtin_types_compatible_p): New test function.
+       * gcc.dg/pr70281.c: New test case.
+
 2016-03-18  Christophe Lyon  <christophe.lyon@linaro.org>
 
        PR target/70113

diff --git a/gcc/testsuite/gcc.dg/plugin/diagnostic-test-expressions-1.c b/gcc/testsuite/gcc.dg/plugin/diagnostic-test-expressions-1.c
index 170060f9a2123bcb99c1383ac19c5b60f4775529..937293613884b5acf029f32470b333695f99e9a6 100644 (file)
--- a/gcc/testsuite/gcc.dg/plugin/diagnostic-test-expressions-1.c
+++ b/gcc/testsuite/gcc.dg/plugin/diagnostic-test-expressions-1.c
@@ -534,6 +534,24 @@ void test_builtin_choose_expr (int i)
 }
 
 extern int f (int);
+
+void test_builtin_types_compatible_p (unsigned long i)
+{
+  __emit_expression_range (0,
+                          f (i) + __builtin_types_compatible_p (long, int)); /* { dg-warning "range" } */
+/* { dg-begin-multiline-output "" }
+       f (i) + __builtin_types_compatible_p (long, int));
+       ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+   { dg-end-multiline-output "" } */
+
+  __emit_expression_range (0,
+                          __builtin_types_compatible_p (long, int) + f (i)); /* { dg-warning "range" } */
+/* { dg-begin-multiline-output "" }
+       __builtin_types_compatible_p (long, int) + f (i));
+       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
+   { dg-end-multiline-output "" } */
+}
+
 void test_builtin_call_with_static_chain (int i, void *ptr)
 {
   __emit_expression_range (0, __builtin_call_with_static_chain (f (i), ptr));  /* { dg-warning "range" } */

diff --git a/gcc/testsuite/gcc.dg/pr70281.c b/gcc/testsuite/gcc.dg/pr70281.c
new file mode 100644 (file)
index 0000000..9447fb1
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr70281.c
@@ -0,0 +1,9 @@
+/* { dg-options "-Wall -fdiagnostics-show-caret" } */
+int bch_stats_show ()
+{
+  return __builtin_types_compatible_p (unsigned, int) ? "" : "";  /* { dg-warning "cast" } */
+/* { dg-begin-multiline-output "" }
+   return __builtin_types_compatible_p (unsigned, int) ? "" : "";
+          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
+   { dg-end-multiline-output "" } */
+}