i965: Switch types D->UD when possible to allow compaction.
authorMatt Turner <mattst88@gmail.com>
Sat, 17 May 2014 22:54:05 +0000 (15:54 -0700)
committerMatt Turner <mattst88@gmail.com>
Mon, 26 May 2014 20:58:58 +0000 (13:58 -0700)
Number of compacted instructions: 827404 -> 833045 (0.68%)

Reviewed-by: Eric Anholt <eric@anholt.net>
src/mesa/drivers/dri/i965/brw_eu_emit.c

index f831413cd477d30f9e7aeb6e3129a8b9ce0e1f47..7448512a7b57eb41cc1f52293ff9e751e7d37f92 100644 (file)
@@ -295,6 +295,16 @@ validate_reg(struct brw_instruction *insn, struct brw_reg reg)
    /* 10. Check destination issues. */
 }
 
+static bool
+is_compactable_immediate(unsigned imm)
+{
+   /* We get the low 12 bits as-is. */
+   imm &= ~0xfff;
+
+   /* We get one bit replicated through the top 20 bits. */
+   return imm == 0 || imm == 0xfffff000;
+}
+
 void
 brw_set_src0(struct brw_compile *p, struct brw_instruction *insn,
             struct brw_reg reg)
@@ -373,6 +383,17 @@ brw_set_src0(struct brw_compile *p, struct brw_instruction *insn,
           insn->bits1.da1.src0_reg_type == BRW_HW_REG_TYPE_F) {
          insn->bits1.da1.src0_reg_type = BRW_HW_REG_IMM_TYPE_VF;
       }
+
+      /* There are no mappings for dst:d | i:d, so if the immediate is suitable
+       * set the types to :UD so the instruction can be compacted.
+       */
+      if (is_compactable_immediate(insn->bits3.ud) &&
+          insn->header.destreg__conditionalmod == BRW_CONDITIONAL_NONE &&
+          insn->bits1.da1.src0_reg_type == BRW_HW_REG_TYPE_D &&
+          insn->bits1.da1.dest_reg_type == BRW_HW_REG_TYPE_D) {
+         insn->bits1.da1.src0_reg_type = BRW_HW_REG_TYPE_UD;
+         insn->bits1.da1.dest_reg_type = BRW_HW_REG_TYPE_UD;
+      }
    }
    else
    {