[gdb/testsuite] Handle removed valgrind option --db-attach

When running valgrind-db-attach.exp with valgrind version 3.13.0, we get:
...
PASS: gdb.base/valgrind-db-attach.exp: spawn valgrind
valgrind: Unknown option: --db-attach=yes
valgrind: Use --help for more information or consult the user manual.
ERROR: Process no longer exists
UNRESOLVED: gdb.base/valgrind-db-attach.exp: valgrind started
...

The valgrind option --db-attach has been deprecated in version 3.10.0, and
removed in version 3.11.0.

Fix valgrind-db-attach.exp to replace the ERROR/UNRESOLVED with:
...
UNSUPPORTED: gdb.base/valgrind-db-attach.exp: valgrind started
...

Tested on x86_64-linux.

2018-10-24  Tom de Vries  <tdevries@suse.de>

	* gdb.base/valgrind-db-attach.exp: Handle removed support for
	--db-attach in valgrind.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 447578ee6f3616cf2e015d49af06cff234bdc545..99d1e8530faf52f2e877c344d5ce42aae19e6411 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2018-10-24  Tom de Vries  <tdevries@suse.de>
+
+       * gdb.base/valgrind-db-attach.exp: Handle removed support for
+       --db-attach in valgrind.
+
 2018-10-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 
        * gdb.arch/riscv-reg-aliases.c: New file.

diff --git a/gdb/testsuite/gdb.base/valgrind-db-attach.exp b/gdb/testsuite/gdb.base/valgrind-db-attach.exp
index 3be6af5ca94c81290413ca69bf869d428af37910..3e40283a95526b71d52ac59e74f372bb3e55f837 100644 (file)
--- a/gdb/testsuite/gdb.base/valgrind-db-attach.exp
+++ b/gdb/testsuite/gdb.base/valgrind-db-attach.exp
@@ -51,6 +51,10 @@ set use_gdb_stub 1
 set test "valgrind started"
 # The trailing '.' differs for different memcheck versions.
 gdb_test_multiple "" $test {
+    -re "valgrind: Unknown option: --db-attach=yes" {
+       unsupported $test
+       return -1
+    }
     -re "Memcheck, a memory error detector\\.?\r\n" {
        pass $test
     }