gdb/testsuite: Remove duplicates from gdb.threads/staticthreads.ex
authorLancelot SIX <lsix@lancelotsix.com>
Tue, 23 Nov 2021 16:40:24 +0000 (16:40 +0000)
committerLancelot SIX <lsix@lancelotsix.com>
Fri, 7 Jan 2022 22:43:34 +0000 (22:43 +0000)
When running the testsuite, I have:

    Running .../gdb/testsuite/gdb.threads/staticthreads.exp ...
    DUPLICATE: gdb.threads/staticthreads.exp: couldn't compile staticthreads.c: unrecognized error

Fix by using foreach_with_prefix instead of foreach when preparing the
test case.

Testeed on x86_64-linux both in a setup where the test fails to prepare
and in a setup where the test fails to setup.

gdb/testsuite/gdb.threads/staticthreads.exp

index cc4867dd459a273e3919c5997b8aca7bcf94357f..788fb53b21b38078df0914b9f60f8cff90a497bb 100644 (file)
@@ -22,7 +22,7 @@
 standard_testfile
 set static_flag "-static"
 
-foreach have_tls { "-DHAVE_TLS" "" } {
+foreach_with_prefix have_tls { "-DHAVE_TLS" "" } {
     if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \
             executable \
             [list debug "additional_flags=${static_flag} ${have_tls}" \