Arm64: fix build with old glibc
authorJan Beulich <jbeulich@suse.com>
Mon, 11 Nov 2019 12:27:47 +0000 (13:27 +0100)
committerJan Beulich <jbeulich@suse.com>
Mon, 11 Nov 2019 12:27:47 +0000 (13:27 +0100)
Some old glibc versions have string.h surface "index", which some
compilers then warn about if shadowed by a local variable. Re-use an
existing variable instead.

opcodes/ChangeLog
opcodes/aarch64-opc.c

index 04442417c960676355695ec838b1f08f62dca3d0..1f9d4a545ea8c07cc7557a1529eda66bbf2ce82c 100644 (file)
@@ -1,3 +1,8 @@
+2019-11-11  Jan Beulich  <jbeulich@suse.com>
+
+       * aarch64-opc.c (operand_general_constraint_met_p): Replace
+       "index" local variable by that of the already existing "num".
+
 2019-11-08  H.J. Lu  <hongjiu.lu@intel.com>
 
        PR gas/25167
index 11b04b58bbdfb19f0b20447b215079fe1060d1e8..61547b403df47a3d23361019799b00e285290969 100644 (file)
@@ -2546,17 +2546,14 @@ operand_general_constraint_met_p (const aarch64_opnd_info *opnds, int idx,
        case AARCH64_OPND_SVE_SHRIMM_PRED:
        case AARCH64_OPND_SVE_SHRIMM_UNPRED:
        case AARCH64_OPND_SVE_SHRIMM_UNPRED_22:
+         num = (type == AARCH64_OPND_SVE_SHRIMM_UNPRED_22) ? 2 : 1;
+         size = aarch64_get_qualifier_esize (opnds[idx - num].qualifier);
+         if (!value_in_range_p (opnd->imm.value, 1, 8 * size))
            {
-             unsigned int index =
-               (type == AARCH64_OPND_SVE_SHRIMM_UNPRED_22) ? 2 : 1;
-             size = aarch64_get_qualifier_esize (opnds[idx - index].qualifier);
-             if (!value_in_range_p (opnd->imm.value, 1, 8 * size))
-               {
-                 set_imm_out_of_range_error (mismatch_detail, idx, 1, 8*size);
-                 return 0;
-               }
-             break;
-          }
+             set_imm_out_of_range_error (mismatch_detail, idx, 1, 8*size);
+             return 0;
+           }
+         break;
 
        default:
          break;