panfrost/midgard: Don't force constant on VLUT

Previously, we forced a #0 inline constant tacked on for the lut
instructions to mirror the blob's behaviour, which caused some
suboptimal codegen due to our constant inlining implementation. Instead,
just don't force a constant at all.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Tested-by: Tomeu Vizoso <tomeu.vizoso@collabora.com

diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/src/gallium/drivers/panfrost/midgard/midgard_compile.c
index 65822d3b28f188ab7561d67e783c3c053f3ef60a..f533572c05d0d99c11052a68a2fe803182c1b564 100644 (file)
--- a/src/gallium/drivers/panfrost/midgard/midgard_compile.c
+++ b/src/gallium/drivers/panfrost/midgard/midgard_compile.c
@@ -1069,7 +1069,6 @@ emit_alu(compiler_context *ctx, nir_alu_instr *instr)
                         .src0 = quirk_flipped_r24 ? SSA_UNUSED_1 : src0,
                         .src1 = quirk_flipped_r24 ? src0         : src1,
                         .dest = dest,
-                        .inline_constant = (nr_inputs == 1) && !quirk_flipped_r24
                 }
         };