Don't change current program space in exec_target::close

Now that we've removed the macros and moved various functions to be
methods on program_space (removing uses of current_program_space),
it's clear that exec_target::close can operate on program spaces
without changing the current program space.

gdb/ChangeLog
2020-10-29  Tom Tromey  <tom@tromey.com>

	* exec.c (exec_target::close): Don't change current program
	space.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4096a1bff52b75eed1f53068f0fcf6c578717e47..3dff81ac62a3e09139839bc92317ce49062fd2a0 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-10-29  Tom Tromey  <tom@tromey.com>
+
+       * exec.c (exec_target::close): Don't change current program
+       space.
+
 2020-10-29  Tom Tromey  <tom@tromey.com>
 
        * symfile.c (add_symbol_file_command): Update.

diff --git a/gdb/exec.c b/gdb/exec.c
index 9c4d9bef908afbb070f4bde421d195c0ad39dd25..8ab71621d2ead9009f19731b6ef2ef838fe30e64 100644 (file)
--- a/gdb/exec.c
+++ b/gdb/exec.c
@@ -154,11 +154,8 @@ exec_target_open (const char *args, int from_tty)
 void
 exec_target::close ()
 {
-  scoped_restore_current_program_space restore_pspace;
-
   for (struct program_space *ss : program_spaces)
     {
-      set_current_program_space (ss);
       ss->target_sections.clear ();
       ss->exec_close ();
     }