Convert fatal to error in remote_prepare

This commit converts a call to fatal in remote_prepare with a call to
error.  remote_prepare is called precisely once, from main, at a point
where jumping to toplevel will call exit (1), so error and fatal are
functionally equivalent at this point.  Note that remote_prepare calls
perror_with_name (which calls error) so callers of remote_prepare must
already handle the fact that it may exit via longjmp.

gdb/gdbserver/ChangeLog:

	* remote-utils.c (remote_prepare): Replace fatal with error.

diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index c3e4c935f066c4ef9678e000a4e8db71d9619698..dd89aaba4d4e492e041e86358adda00ed9f45823 100644 (file)
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,7 @@
+2014-08-28  Gary Benson  <gbenson@redhat.com>
+
+       * remote-utils.c (remote_prepare): Replace fatal with error.
+
 2014-08-28  Gary Benson  <gbenson@redhat.com>
 
        * linux-low.c (linux_async): Replace fatal with warning.

diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c
index 327677a0ea4a0b9fe54fa32c6bb1ba84bb35434a..81b9af3015ea86069492bc8504c57bec468d2136 100644 (file)
--- a/gdb/gdbserver/remote-utils.c
+++ b/gdb/gdbserver/remote-utils.c
@@ -247,7 +247,7 @@ remote_prepare (char *name)
 
   port = strtoul (port_str + 1, &port_end, 10);
   if (port_str[1] == '\0' || *port_end != '\0')
-    fatal ("Bad port argument: %s", name);
+    error ("Bad port argument: %s", name);
 
 #ifdef USE_WIN32API
   if (!winsock_initialized)