iris: Fix downcast of bound_vertex_buffers from uint64_t to int
authorKenneth Graunke <kenneth@whitecape.org>
Tue, 28 Apr 2020 21:04:58 +0000 (14:04 -0700)
committerMarge Bot <eric+marge@anholt.net>
Wed, 29 Apr 2020 06:50:54 +0000 (06:50 +0000)
This is the wrong data type, the original field - and the values we're
adding in - are both 64-bit unsigned.  Keep the original data type.

Thanks to Dave Airlie for finding this while reading the code.

Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4802>

src/gallium/drivers/iris/iris_state.c

index d708f6a45bc15ed7e2e21a3e84c8d27a6f439735..30fbd59c15e2975f530cdc31434dcad6c5d723c8 100644 (file)
@@ -5988,7 +5988,7 @@ iris_upload_dirty_render_state(struct iris_context *ice,
 
    if (dirty & IRIS_DIRTY_VERTEX_BUFFERS) {
       int count = util_bitcount64(ice->state.bound_vertex_buffers);
-      int dynamic_bound = ice->state.bound_vertex_buffers;
+      uint64_t dynamic_bound = ice->state.bound_vertex_buffers;
 
       if (ice->state.vs_uses_draw_params) {
          assert(ice->draw.draw_params.res);