mapi/glapi: Don't allocate a page for every function on windows.
authorJosé Fonseca <jfonseca@vmware.com>
Fri, 7 May 2010 06:31:44 +0000 (07:31 +0100)
committerJosé Fonseca <jfonseca@vmware.com>
Fri, 7 May 2010 06:31:44 +0000 (07:31 +0100)
src/mapi/mapi/u_execmem.c
src/mapi/mapi/u_thread.h

index fae2c75c0ec104e05ca717fb1f1a3d4a74f79e31..00df8300de3937e67ed11125bb810a439a8b0b55 100644 (file)
 #include "u_execmem.h"
 
 
+#define EXEC_MAP_SIZE (4*1024)
+
+u_mutex_declare_static(exec_mutex);
+
+static unsigned int head = 0;
+
+static unsigned char *exec_mem = (unsigned char *)0;
+
+
 #if defined(__linux__) || defined(__OpenBSD__) || defined(_NetBSD__) || defined(__sun)
 
 #include <unistd.h>
 #endif
 
 
-#define EXEC_MAP_SIZE (4*1024)
-
-u_mutex_declare_static(exec_mutex);
-
-static unsigned int head = 0;
-
-static unsigned char *exec_mem = NULL;
-
-
 /*
  * Dispatch stubs are of fixed size and never freed. Thus, we do not need to
  * overlay a heap, we just mmap a page and manage through an index.
@@ -85,6 +85,37 @@ init_map(void)
 }
 
 
+#elif defined(_WIN32)
+
+#include <windows.h>
+
+
+/*
+ * Avoid Data Execution Prevention.
+ */
+
+static int
+init_map(void)
+{
+   exec_mem = VirtualAlloc(NULL, EXEC_MAP_SIZE, MEM_COMMIT, PAGE_EXECUTE_READWRITE);
+
+   return (exec_mem != NULL);
+}
+
+
+#else
+
+static int
+init_map(void)
+{
+   exec_mem = malloc(EXEC_MAP_SIZE);
+
+   return (exec_mem != NULL);
+}
+
+
+#endif
+
 void *
 u_execmem_alloc(unsigned int size)
 {
@@ -110,29 +141,3 @@ bail:
 }
 
 
-#elif defined(_WIN32)
-
-#include <windows.h>
-
-
-/*
- * Avoid Data Execution Prevention.
- */
-
-void *
-u_execmem_alloc(unsigned int size)
-{
-   return VirtualAlloc(NULL, size, MEM_COMMIT, PAGE_EXECUTE_READWRITE);
-}
-
-
-#else
-
-void *
-u_execmem_alloc(unsigned int size)
-{
-   return malloc(size);
-}
-
-
-#endif
index 992dbaace9676e5a5c145c9c2ec3a15939d5c99c..b4487a3400f86a8f2aa8ed9dbf692db16482c076 100644 (file)
@@ -95,8 +95,9 @@ struct u_tsd {
 
 typedef CRITICAL_SECTION u_mutex;
 
+/* http://locklessinc.com/articles/pthreads_on_windows/ */
 #define u_mutex_declare_static(name) \
-   /* static */ u_mutex name = { 0, 0, 0, 0, 0, 0 }
+   /* static */ u_mutex name = {(void*)-1, -1, 0, 0, 0, 0}
 
 #define u_mutex_init(name)    InitializeCriticalSection(&name)
 #define u_mutex_destroy(name) DeleteCriticalSection(&name)