2005-02-07 Andrew Cagney <cagney@gnu.org>

	* cp-valprint.c, c-valprint.c, infcall.c: Use value_contents or
	value_contents_writeable, include note that there are problems.
	* breakpoint.c, infcall.c: Use VALUE_LVAL.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 9d3c61fa7a618b193d789c9a94a4c44c82c1ff8b..6f7da53301ec2387c4984465a3b39bfb80517c2f 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
 2005-02-07  Andrew Cagney  <cagney@gnu.org>
 
+       * cp-valprint.c, c-valprint.c, infcall.c: Use value_contents or
+       value_contents_writeable, include note that there are problems.
+       * breakpoint.c, infcall.c: Use VALUE_LVAL.
+
        * value.h (set_value_offset): Declare.
        * value.c (set_value_offset): Declare.
        * gnu-v2-abi.c, jv-valprint.c, valarith.c, valops.c: Update.

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 0a117d28246ff5a4985419c85c7ef7abdead895d..da37ea85738f77ee37dfd8fa1f29f959d001daa2 100644 (file)
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -5821,9 +5821,10 @@ can_use_hardware_watchpoint (struct value *v)
                }
            }
        }
-      else if (v->lval != not_lval && deprecated_value_modifiable (v) == 0)
+      else if (VALUE_LVAL (v) != not_lval
+              && deprecated_value_modifiable (v) == 0)
        return 0;       /* ??? What does this represent? */
-      else if (v->lval == lval_register)
+      else if (VALUE_LVAL (v) == lval_register)
        return 0;       /* cannot watch a register with a HW watchpoint */
     }
 

diff --git a/gdb/c-valprint.c b/gdb/c-valprint.c
index 948f5d87dd4b3ed0cb23b6ce2aa8a52bf197e608..e9372fb4b96a17abab8082a737b6bd853bd35551 100644 (file)
--- a/gdb/c-valprint.c
+++ b/gdb/c-valprint.c
@@ -551,7 +551,8 @@ c_value_print (struct value *val, struct ui_file *stream, int format,
                   type = lookup_reference_type (real_type);
                 }
              /* JYG: Need to adjust pointer value. */
-              val->aligner.contents[0] -= top;
+             /* NOTE: cagney/2005-01-02: THIS IS BOGUS.  */
+              value_contents_writeable (val)[0] -= top;
 
               /* Note: When we look up RTTI entries, we don't get any 
                  information on const or volatile attributes */

diff --git a/gdb/cp-valprint.c b/gdb/cp-valprint.c
index 2cff8e7df5ac3f703c445d881275aab65d7f3cfb..d662d31bc1d7df76536d5da43a6591401573b2b0 100644 (file)
--- a/gdb/cp-valprint.c
+++ b/gdb/cp-valprint.c
@@ -784,7 +784,8 @@ cp_print_hpacc_virtual_table_entries (struct type *type, int *vfuncs,
          if (value_lazy (vf))
            (void) value_fetch_lazy (vf);
          /* adjust by offset */
-         vf->aligner.contents[0] += 4 * (HP_ACC_VFUNC_START + vx);
+         /* NOTE: cagney/2005-01-02: THIS IS BOGUS.  */
+         value_contents_writeable (vf)[0] += 4 * (HP_ACC_VFUNC_START + vx);
          vf = value_ind (vf);  /* get the entry */
          /* make it a pointer */
          deprecated_set_value_type (vf, value_type (v));

diff --git a/gdb/infcall.c b/gdb/infcall.c
index f91777c4dae13fe1f44539bf9803f754d7b365aa..e2ef6b41a7a140413c8406b784bf067a8a0a7292 100644 (file)
--- a/gdb/infcall.c
+++ b/gdb/infcall.c
@@ -536,10 +536,11 @@ call_function_by_hand (struct value *function, int nargs, struct value **args)
                       this point.  */
                    /* Go see if the actual parameter is a variable of
                       type pointer to function or just a function.  */
-                   if (args[i]->lval == not_lval)
+                   if (VALUE_LVAL (args[i]) == not_lval)
                      {
                        char *arg_name;
-                       if (find_pc_partial_function ((CORE_ADDR) args[i]->aligner.contents[0], &arg_name, NULL, NULL))
+                       /* NOTE: cagney/2005-01-02: THIS IS BOGUS.  */
+                       if (find_pc_partial_function ((CORE_ADDR) value_contents (args[i])[0], &arg_name, NULL, NULL))
                          error ("\
 You cannot use function <%s> as argument. \n\
 You must use a pointer to function type variable. Command ignored.", arg_name);